Review 11.5 Merged

76257[TASK] Update to PHPStan 1.8.11

Christian Kuhn CR +2 V +2 Easy +18 −28 updated 10/25/22, 10:43

Commit message

Also update the PHPUnit PHPStan configuration.

This update gets rid of some false positives.

Run commands:

> composer req --dev phpstan/phpstan:^1.8.11
> composer req --dev phpstan/phpstan-phpunit:^1.1.3
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Christian Kuhn uploaded patch set 1 10/25/22, 10:27

  2. core-ci voted on patch set 1 V +1 10/25/22, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32732

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 10/25/22, 10:42

  4. Christian Kuhn merged patch set 2 10/25/22, 10:43