Review main Merged

76258[TASK] Convert FluidTemplateContentObjectTest to functional tests

Nikita Hovratov CR +2 V +2 Expert +819 −1455 updated 10/29/22, 13:32

Commit message

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 50

Show 30 more files

Review log 1521

  1. Nikita Hovratov uploaded patch set 1 10/25/22, 11:51

  2. core-ci voted on patch set 1 V +1 10/25/22, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32737

  3. Nikita Hovratov uploaded patch set 2 10/25/22, 15:35

  4. Nikita Hovratov uploaded patch set 3 10/25/22, 15:38

  5. core-ci voted on patch set 2 V -1 10/25/22, 15:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32749

  6. core-ci voted on patch set 3 V -1 10/25/22, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32750

  7. Nikita Hovratov uploaded patch set 4 10/26/22, 20:26

  8. core-ci voted on patch set 4 V +1 10/26/22, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32814

  9. Oliver Klee voted on patch set 4 V +1 10/27/22, 10:34

  10. Stefan Bürk commented on patch set 4 10/27/22, 11:05

    FluidTemplateContentObjectTest.php:513

    Is there a reason not to use the SiteBasedTestTraite and the corresponding methods for writing site configurations, which I don't see ? ->writeSiteConfiguration() ->buildSiteConfiguration() ->buildDefaultLanguageConfiguration() like in the other ext:frontend functional tests ?
  11. Stefan Bürk commented on patch set 4 CR -1 10/27/22, 11:14

    ContentObjectCurrentValue.php:18

    Namespace of text fixture extension should follow a normal extension build up, starting a own one - and not "extending" from the mono-repo following folder conventions. ``` <vendor>\<extensionname>\... ``` Another quest would be to streamline this, but is superseeded by need from the prophecy quest. We (lolli&maddy and I) came up with a naming scheme for fixture extensions namespaces like ``` TYPO3Tests\CamelCaseExtensionName\ # or for this fixture extension TYPO3Tests\TestFluidTemplate\ ``` This should be added as psr-4 autoload namespace to the extension composer.json, and additionally configured as psr-4 namespace in the root composer.json as autoload-dev ``` "TYPO3Tests\\TestLogger\\": "typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_logger/Classes/", "TYPO3Tests\\TestTyposcriptAstFunctionEvent\\": "typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_ast_function_event/Classes/" ``` That helps for future composer based installations and better psr-4 namespace checks using composer instead of custom solution and avoiding classmap autoload definition in root composer.json autoload-dev.
  12. Nikita Hovratov uploaded patch set 5 10/27/22, 12:41

  13. Nikita Hovratov commented on patch set 5 10/27/22, 12:42

    FluidTemplateContentObjectTest.php:513 Reply

    Thanks for the hint!

    ContentObjectCurrentValue.php:18 Reply

    Done
  14. core-ci voted on patch set 5 V -1 10/27/22, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32840

  15. Nikita Hovratov uploaded patch set 6 10/27/22, 13:03

  16. core-ci voted on patch set 6 V +1 10/27/22, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32841

  17. Stefan Bürk voted on patch set 6 V +1 CR +1 10/27/22, 17:40

  18. Oliver Klee voted on patch set 6 V +1 10/27/22, 18:03

  19. Benni Mack voted on patch set 6 CR +1 10/28/22, 08:07

  20. Nikita Hovratov voted on patch set 6 V +2 CR +2 10/29/22, 13:32

  21. Nikita Hovratov merged patch set 7 10/29/22, 13:32