76258[TASK] Convert FluidTemplateContentObjectTest to functional tests
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 50
- typo3/sysext/frontend/Tests/Functional/ContentObject/Fixtures/pages.csvnew+3 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/FluidTemplateContentObjectTest.php2+425 −82
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Classes/ContentObjectCurrentValue.php2new+29 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/assets.typoscriptnew+6 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/current.typoscriptnew+6 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/data.typoscriptnew+6 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/file.typoscriptnew+5 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/fluid_template_stdwrap.typoscriptnew+10 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/format.typoscriptnew+9 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/format_stdwrap.typoscriptnew+11 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/layout_root_path.typoscriptnew+9 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/layout_root_paths_fallback.typoscriptnew+13 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/layout_root_paths_stdwrap.typoscriptnew+12 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/layout_root_path_and_paths_fallback.typoscriptnew+13 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/layout_root_path_stdwrap.typoscriptnew+10 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/nested_fluid_template.typoscriptnew+17 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/nested_fluid_template_with_layout.typoscriptnew+26 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/partial.typoscriptnew+9 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/partial_root_paths_fallback.typoscriptnew+12 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/partial_root_paths_stdwrap.typoscriptnew+10 −0
Show 30 more files
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/partial_root_path_and_paths_fallback.typoscriptnew+13 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/partial_stdwrap.typoscriptnew+10 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/settings.typoscriptnew+12 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/template.typoscriptnew+6 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/template_name.typoscriptnew+8 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/template_name_stdwrap.typoscriptnew+9 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/template_rootpaths_stdwrap.typoscriptnew+11 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/variables.typoscriptnew+14 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/variables_reserved_current.typoscriptnew+14 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TypoScript/variables_reserved_data.typoscriptnew+14 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/FoobarLayouts/Foobar.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/FoobarPartials/Foobar.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/FoobarTemplates/Foobar.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/FoobarTemplates/Foobar.xmlnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/LayoutOverrides/Layouts/Default.htmlnew+2 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/Layouts/AlternativeLayout.htmlnew+2 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/Layouts/Default.htmlnew+2 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/PartialOverrides/Partials/Component.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/Partials/Component.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/Templates/AlternativeTemplate.htmlnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/Templates/Main.htmlnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/Templates/Settings.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/Templates/Variables.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Private/Templates/WithPartial.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Resources/Public/Icons/Extension.svgnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/composer.jsonnew+16 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/ext_emconf.phpnew+18 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/ext_localconf.phpnew+5 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.phpdeleted+0 −1373
- composer.json+1 −0
Review log 1521
-
Nikita Hovratov uploaded patch set 1 10/25/22, 11:51
-
core-ci voted on patch set 1 V +1 10/25/22, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32737
-
Nikita Hovratov uploaded patch set 2 10/25/22, 15:35
-
Nikita Hovratov uploaded patch set 3 10/25/22, 15:38
-
core-ci voted on patch set 2 V -1 10/25/22, 15:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32749
-
core-ci voted on patch set 3 V -1 10/25/22, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32750
-
Nikita Hovratov uploaded patch set 4 10/26/22, 20:26
-
core-ci voted on patch set 4 V +1 10/26/22, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32814
-
Oliver Klee voted on patch set 4 V +1 10/27/22, 10:34
-
Stefan Bürk commented on patch set 4 10/27/22, 11:05
-
Stefan Bürk commented on patch set 4 CR -1 10/27/22, 11:14
ContentObjectCurrentValue.php:18Namespace of text fixture extension should follow a normal extension build up, starting a own one - and not "extending" from the mono-repo following folder conventions. ``` <vendor>\<extensionname>\... ``` Another quest would be to streamline this, but is superseeded by need from the prophecy quest. We (lolli&maddy and I) came up with a naming scheme for fixture extensions namespaces like ``` TYPO3Tests\CamelCaseExtensionName\ # or for this fixture extension TYPO3Tests\TestFluidTemplate\ ``` This should be added as psr-4 autoload namespace to the extension composer.json, and additionally configured as psr-4 namespace in the root composer.json as autoload-dev ``` "TYPO3Tests\\TestLogger\\": "typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_logger/Classes/", "TYPO3Tests\\TestTyposcriptAstFunctionEvent\\": "typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_ast_function_event/Classes/" ``` That helps for future composer based installations and better psr-4 namespace checks using composer instead of custom solution and avoiding classmap autoload definition in root composer.json autoload-dev. -
Nikita Hovratov uploaded patch set 5 10/27/22, 12:41
-
Nikita Hovratov commented on patch set 5 10/27/22, 12:42
FluidTemplateContentObjectTest.php:513ReplyThanks for the hint!ContentObjectCurrentValue.php:18ReplyDone -
core-ci voted on patch set 5 V -1 10/27/22, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32840
-
Nikita Hovratov uploaded patch set 6 10/27/22, 13:03
-
core-ci voted on patch set 6 V +1 10/27/22, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32841
-
Stefan Bürk voted on patch set 6 V +1 CR +1 10/27/22, 17:40
-
Oliver Klee voted on patch set 6 V +1 10/27/22, 18:03
-
Benni Mack voted on patch set 6 CR +1 10/28/22, 08:07
-
Nikita Hovratov voted on patch set 6 V +2 CR +2 10/29/22, 13:32
-
Nikita Hovratov merged patch set 7 10/29/22, 13:32
FluidTemplateContentObjectTest.php:513