Review main Merged

76259[TASK] Add contextual balloon menu for RTE Links

Benjamin Kott CR +2 V +2 Hard +343 −88 updated 11/04/22, 10:38

Commit message

Adapting the link behavior to match the default CKEditor5
linking behavior. We are now also introducing the contextual
balloon menu. This change makes the need for a dedicated
unlink button in the menu bar obsolete and eases the use
of editing links.

The ballon menu opens with a single click and provides
information about the current link as well as
edit and unlink options.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 915

  1. Benjamin Kott uploaded patch set 1 10/25/22, 12:44

  2. core-ci voted on patch set 1 V +1 10/25/22, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32739

  3. Benjamin Kott uploaded patch set 2 11/02/22, 14:45

  4. core-ci voted on patch set 2 V +1 11/02/22, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32987

  5. Benjamin Kott uploaded patch set 3 11/03/22, 08:56

  6. core-ci voted on patch set 3 V +1 11/03/22, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33023

  7. Benjamin Kott uploaded patch set 4 11/03/22, 13:40

  8. core-ci voted on patch set 4 V -1 11/03/22, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33050

  9. Benjamin Kott uploaded patch set 5 11/03/22, 14:50

  10. core-ci voted on patch set 5 V -1 11/03/22, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33052

  11. Benjamin Kott uploaded patch set 6 11/04/22, 09:29

  12. core-ci voted on patch set 6 V +1 11/04/22, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33095

  13. Benni Mack commented on patch set 6 V +1 CR +1 11/04/22, 09:50

    nice one. As a further step we could resolve the link to a page within the baloon. currently: "t3://page?id=232"
  14. Andreas Kienast voted on patch set 6 V +2 CR +2 11/04/22, 10:38

  15. Andreas Kienast merged patch set 7 11/04/22, 10:38