Review main Merged

76262[TASK] Make EnableFileServiceTest a functional test

Christian Kuhn CR +2 V +2 Hard +116 −164 updated 10/25/22, 15:09

Commit message

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Christian Kuhn uploaded patch set 1 10/25/22, 14:51

  2. Oliver Klee commented on patch set 1 10/25/22, 14:55

    EnableFileServiceTest.php:26

    Can we skip the DB init in this testcase?
  3. Christian Kuhn commented on patch set 1 10/25/22, 14:56

    EnableFileServiceTest.php:26 Reply

    good point!
  4. Christian Kuhn uploaded patch set 2 10/25/22, 14:57

  5. Christian Kuhn commented on patch set 1 10/25/22, 14:57

    EnableFileServiceTest.php:26 Reply

    Done
  6. core-ci voted on patch set 1 V +1 10/25/22, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32744

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 10/25/22, 15:03

  8. core-ci voted on patch set 2 V +1 10/25/22, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32746

  9. Anja Leichsenring voted on patch set 2 V +2 CR +2 10/25/22, 15:09

  10. Anja Leichsenring merged patch set 3 10/25/22, 15:09