Review main Merged

76264[TASK] Clean up DocumentationFile

Christian Kuhn CR +2 V +2 Hard +187 −361 updated 10/26/22, 07:25

Commit message

The class can be hardended a bit and some unused
methods removed. The tests are turned into
functional tests.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1

Issues 1

Files 3

Review log 1013

  1. Christian Kuhn uploaded patch set 1 10/25/22, 22:07

  2. Christian Kuhn uploaded patch set 2 10/25/22, 22:12

  3. core-ci voted on patch set 1 V -1 10/25/22, 22:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32763

  4. core-ci voted on patch set 2 V +1 10/25/22, 22:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32764

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 10/26/22, 06:35

  6. Andreas Kienast commented on patch set 2 10/26/22, 07:07

    DocumentationFile.php:38

    Property initializer is redundant

    DocumentationFile.php:60

    Unrelated: master is not used anymore
  7. Christian Kuhn uploaded patch set 3 10/26/22, 07:17

  8. Christian Kuhn commented on patch set 3 10/26/22, 07:17

    DocumentationFile.php:38 Reply

    Done

    DocumentationFile.php:60 Reply

    Done
  9. Andreas Kienast voted on patch set 3 V +1 CR +1 10/26/22, 07:20

  10. Anja Leichsenring voted on patch set 3 V +1 CR +1 10/26/22, 07:23

  11. Anja Leichsenring voted on patch set 3 V +2 CR +2 10/26/22, 07:23

  12. Anja Leichsenring merged patch set 4 10/26/22, 07:23

  13. core-ci voted on patch set 3 V +1 10/26/22, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32778