76265[FEATURE] Get multiple items by common key prefix from local storages
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/TypeScript/backend/storage/abstract-client-storage.ts+13 −0
- Build/Sources/TypeScript/backend/tests/backend/storage/browser-storage-test.tsnew+85 −0
- Build/Sources/TypeScript/backend/tests/backend/storage/client-test.tsnew+85 −0
- typo3/sysext/backend/Resources/Public/JavaScript/storage/abstract-client-storage.js+1 −1
- typo3/sysext/backend/Tests/JavaScript/backend/storage/browser-storage-test.jsnew+13 −0
- typo3/sysext/backend/Tests/JavaScript/backend/storage/client-test.jsnew+13 −0
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-98921-GetMultipleItemsByCommonKeyPrefixFromLocalStorages.rstnew+42 −0
Review log 1722
-
Andreas Kienast uploaded patch set 1 10/26/22, 06:49
-
Andreas Kienast commented on patch set 1 10/26/22, 06:50
-
Andreas Kienast uploaded patch set 2 10/26/22, 06:52
-
core-ci voted on patch set 1 V +1 10/26/22, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32774
-
core-ci voted on patch set 2 V +1 10/26/22, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32775
-
Andreas Kienast uploaded patch set 3 10/26/22, 07:40
-
Andreas Kienast commented on patch set 3 10/26/22, 07:41
package.json:50ReplyDone -
core-ci voted on patch set 3 V +1 10/26/22, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32779
-
Andreas Kienast uploaded patch set 4 10/26/22, 08:12
-
Andreas Kienast uploaded patch set 5 10/26/22, 08:14
-
Andreas Kienast uploaded patch set 6 10/26/22, 08:15
-
core-ci voted on patch set 6 V +1 10/26/22, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32783
-
Benni Mack commented on patch set 6 10/26/22, 08:24
any reason we didn't put this in the PersistentStorage? -
Andreas Kienast commented on patch set 6 10/26/22, 08:27
Reply
PersistentStorage uses a PHP backend that needs adoption. It currently also doesn't support unsetting multiple values by a prefix. I'd change this in a separate patch as it involves more work. -
Benni Mack voted on patch set 6 V +1 CR +1 10/26/22, 08:49
-
Chris Müller uploaded patch set 7 10/26/22, 16:26
-
core-ci voted on patch set 7 V +1 10/26/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32812
-
Andreas Kienast commented on patch set 7 10/26/22, 16:39
Thank you very much, Chris! -
Benni Mack voted on patch set 7 V +1 CR +1 10/27/22, 13:57
-
Stefan Bürk voted on patch set 7 V +1 CR +1 10/28/22, 15:20
-
Andreas Kienast voted on patch set 7 V +2 CR +2 10/28/22, 18:05
-
Andreas Kienast merged patch set 8 10/28/22, 18:05
package.json:50