Review main Merged

76265[FEATURE] Get multiple items by common key prefix from local storages

Andreas Kienast CR +2 V +2 Hard +252 −1 updated 10/28/22, 18:05

Commit message

A new method `getByPrefix()` is added to the module
`@typo3/backend/storage/abstract-client-storage`, affecting its
implementations

* `@typo3/backend/storage/browser-session`
* `@typo3/backend/storage/client`

A developer is now able to obtain multiple items prefixed by a given
key either from `localStorage` or `sessionStorage`.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1722

  1. Andreas Kienast uploaded patch set 1 10/26/22, 06:49

  2. Andreas Kienast commented on patch set 1 10/26/22, 06:50

    package.json:50

    This change is required to have the comparator `toHaveSize()` defined in TypeScript.
  3. Andreas Kienast uploaded patch set 2 10/26/22, 06:52

  4. core-ci voted on patch set 1 V +1 10/26/22, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32774

  5. core-ci voted on patch set 2 V +1 10/26/22, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32775

  6. Andreas Kienast uploaded patch set 3 10/26/22, 07:40

  7. Andreas Kienast commented on patch set 3 10/26/22, 07:41

    package.json:50 Reply

    Done
  8. core-ci voted on patch set 3 V +1 10/26/22, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32779

  9. Andreas Kienast uploaded patch set 4 10/26/22, 08:12

  10. Andreas Kienast uploaded patch set 5 10/26/22, 08:14

  11. Andreas Kienast uploaded patch set 6 10/26/22, 08:15

  12. core-ci voted on patch set 6 V +1 10/26/22, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32783

  13. Benni Mack commented on patch set 6 10/26/22, 08:24

    any reason we didn't put this in the PersistentStorage?
  14. Andreas Kienast commented on patch set 6 10/26/22, 08:27

    Reply

    PersistentStorage uses a PHP backend that needs adoption. It currently also doesn't support unsetting multiple values by a prefix. I'd change this in a separate patch as it involves more work.
  15. Benni Mack voted on patch set 6 V +1 CR +1 10/26/22, 08:49

  16. Chris Müller uploaded patch set 7 10/26/22, 16:26

  17. core-ci voted on patch set 7 V +1 10/26/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32812

  18. Andreas Kienast commented on patch set 7 10/26/22, 16:39

    Thank you very much, Chris!
  19. Benni Mack voted on patch set 7 V +1 CR +1 10/27/22, 13:57

  20. Stefan Bürk voted on patch set 7 V +1 CR +1 10/28/22, 15:20

  21. Andreas Kienast voted on patch set 7 V +2 CR +2 10/28/22, 18:05

  22. Andreas Kienast merged patch set 8 10/28/22, 18:05