76268[TASK] Avoid vfsStream in functional tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 16
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.ai.jpgnewbinary
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.bmp.jpgnewbinary
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.eps.jpgnew+7842 −0
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.fax.jpgnewbinary
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.gif.jpgnewbinary
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.jpg.pngnewbinary
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.pdf.jpgnewbinary
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.png.jpgnewbinary
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.ps.jpgnew+7843 −0
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.svg.jpgnew+44 −0
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.tif.jpgnewbinary
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.webp.jpgnewbinary
- typo3/sysext/core/Tests/Functional/Imaging/ImageMagickFileTest.php2+13 −114
- typo3/sysext/core/Tests/Functional/Service/Archive/ZipServiceTest.php+9 −59
- typo3/sysext/form/Tests/Functional/Mvc/Validation/MimeTypeValidatorTest.php+18 −19
- typo3/sysext/seo/Tests/Functional/MetaTag/MetaTagGeneratorTest.php+5 −7
Review log 912
-
Christian Kuhn uploaded patch set 1 10/26/22, 08:34
-
core-ci voted on patch set 1 V -1 10/26/22, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32784
-
Christian Kuhn uploaded patch set 2 10/26/22, 08:50
-
Oliver Klee commented on patch set 2 10/26/22, 08:56
Neat! Only one nitpick concerning the types.ImageMagickFileTest.php:262If we're removing this annotation, then we should change the type declaration from string to string? to mirror the removed annotation (so that it's still explicit). -
core-ci voted on patch set 2 V +1 10/26/22, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32788
-
Christian Kuhn commented on patch set 2 10/26/22, 09:03
ImageMagickFileTest.php:262ReplyDone -
Christian Kuhn uploaded patch set 3 10/26/22, 09:03
-
core-ci voted on patch set 3 V +1 10/26/22, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32789
-
Oliver Klee voted on patch set 3 V +1 CR +1 10/26/22, 09:17
-
Andreas Kienast voted on patch set 3 V +1 CR +1 10/26/22, 09:17
-
Christian Kuhn voted on patch set 3 V +2 CR +2 10/26/22, 09:18
-
Christian Kuhn merged patch set 4 10/26/22, 09:18