Review main Merged

76268[TASK] Avoid vfsStream in functional tests

Christian Kuhn CR +2 V +2 Impossible +15774 −199 updated 10/26/22, 09:18

Commit message

There is little reason to fake filesystems
details within functional tests that use an
isolated instance.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 16

Review log 912

  1. Christian Kuhn uploaded patch set 1 10/26/22, 08:34

  2. core-ci voted on patch set 1 V -1 10/26/22, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32784

  3. Christian Kuhn uploaded patch set 2 10/26/22, 08:50

  4. Oliver Klee commented on patch set 2 10/26/22, 08:56

    Neat! Only one nitpick concerning the types.

    ImageMagickFileTest.php:262

    If we're removing this annotation, then we should change the type declaration from string to string? to mirror the removed annotation (so that it's still explicit).
  5. core-ci voted on patch set 2 V +1 10/26/22, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32788

  6. Christian Kuhn commented on patch set 2 10/26/22, 09:03

    ImageMagickFileTest.php:262 Reply

    Done
  7. Christian Kuhn uploaded patch set 3 10/26/22, 09:03

  8. core-ci voted on patch set 3 V +1 10/26/22, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32789

  9. Oliver Klee voted on patch set 3 V +1 CR +1 10/26/22, 09:17

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 10/26/22, 09:17

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 10/26/22, 09:18

  12. Christian Kuhn merged patch set 4 10/26/22, 09:18