Review main Merged

76269[BUGFIX] Harden LocalizationUtility with empty arguments

Georg Ringer CR +2 V +2 Easy +36 −2 updated 11/03/22, 18:22

Commit message

To avoid exceptions if arguments are given but
empty, an additional check is added in extbase
LocalizationUtility, plus the default in
f:translate is changed back to the same 'null'
value as in v11.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 2330

Show 45 earlier messages
  1. Georg Ringer uploaded patch set 1 10/26/22, 08:41

  2. Georg Ringer commented on patch set 1 10/26/22, 08:44

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/26/22, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32786

  4. Georg Ringer uploaded patch set 2 10/26/22, 09:09

  5. Christian Kuhn updated the commit message in patch set 3 10/26/22, 09:12

  1. Christian Kuhn commented on patch set 3 10/26/22, 09:16

    Not entirely sure if we should do this, I'm still a bit confused, maybe we could adapt Translate VH also as other option? Could we also increase test coverage in TranslateViewHelper a bit to show that it fails without the code change and is fixed with the code change? This VH has various functional tests, i guess it should be do-able to add something to see details with argument handling?
  2. Oliver Klee commented on patch set 3 10/26/22, 09:19

    LocalizationUtility.php:128

    empty in PHP behaves in mysterious ways and should be avoided. Let's use the more explicit !== [] here.
  3. Oliver Klee commented on patch set 4 10/26/22, 09:19

    Published edit on patch set 3.
  4. Oliver Klee commented on patch set 4 10/26/22, 09:19

    LocalizationUtility.php:128 Reply

    Done
  5. Oliver Klee voted on patch set 4 CR +1 10/26/22, 09:20

  6. core-ci voted on patch set 3 V +1 10/26/22, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32791

  7. core-ci voted on patch set 2 V +1 10/26/22, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32790

  8. core-ci voted on patch set 4 V +1 10/26/22, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32792

  9. Christian Kuhn commented on patch set 4 CR -1 10/26/22, 10:02

    i'll -1 for the time being since i really thing added tests regarding arguments handling in TranslateVH would be benefitial.
  10. Georg Ringer commented on patch set 4 10/29/22, 04:46

    The vh is not a problem. Or we can also change the argument back to null if empty, fine for me as well
  11. Benni Mack uploaded patch set 5 11/02/22, 11:41

  12. Benni Mack voted on patch set 5 V +1 CR +1 11/02/22, 11:41

  13. core-ci voted on patch set 5 V +1 11/02/22, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32979

  14. Oliver Klee voted on patch set 5 CR +1 11/02/22, 12:08

  15. Christian Kuhn commented on patch set 5 CR -1 11/02/22, 13:25

    still a bit unsure here: we may still want to change the default of the translate VH again. will have a look soon. hope it's fine to -1 for the moment.
  16. Christian Kuhn uploaded patch set 6 11/03/22, 16:02

  17. Christian Kuhn uploaded patch set 7 11/03/22, 16:04

  18. Benni Mack voted on patch set 7 V +1 CR +1 11/03/22, 16:04

  19. Christian Kuhn voted on patch set 7 V +1 CR +1 11/03/22, 16:06

  20. core-ci voted on patch set 6 V +1 11/03/22, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33054

  21. core-ci voted on patch set 7 V +1 11/03/22, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33055

  22. Georg Ringer voted on patch set 7 V +1 CR +1 11/03/22, 17:05

  23. Oliver Klee voted on patch set 7 CR +1 11/03/22, 17:13

  24. Anja Leichsenring voted on patch set 7 V +2 CR +2 11/03/22, 18:22

  25. Anja Leichsenring merged patch set 8 11/03/22, 18:22