76295[TASK] Make FileBackendTest a functional test
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 2
Files 3
Review log 78
-
Christian Kuhn uploaded patch set 1 10/26/22, 13:10
-
core-ci voted on patch set 1 V +1 10/26/22, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32804
-
Anja Leichsenring voted on patch set 1 V +1 CR +1 10/26/22, 13:19
-
Oliver Klee commented on patch set 1 10/26/22, 13:20
-
Stefan Bürk commented on patch set 1 10/26/22, 13:25
FileBackendTest.php:36ReplyDoes not really matter, has to be cleaned up anyway. BUt that whas the vfs con, no-one really cared. But ack, I think we should adjust the path here. -
Christian Kuhn commented on patch set 1 10/26/22, 13:28
FileBackendTest.php:36Replydoes not matter since the path is removed in tearDown() anyways: switching to something else then needs assumptions or Environment usage to stay stable in case we switch functional tests to composer-based instances. So i decided to keep 'root' dir stuff for now. -
Stefan Bürk voted on patch set 1 V +2 CR +2 10/26/22, 13:29
-
Stefan Bürk merged patch set 2 10/26/22, 13:29
FileBackendTest.php:36