Review main Merged

76295[TASK] Make FileBackendTest a functional test

Christian Kuhn CR +2 V +2 Expert +697 −959 updated 10/26/22, 13:29

Commit message

Moving cache framework related FileBackendTest
unit tests to functional tests needs less mocks
and avoids vfsStream.

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 78

  1. Christian Kuhn uploaded patch set 1 10/26/22, 13:10

  2. core-ci voted on patch set 1 V +1 10/26/22, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32804

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 10/26/22, 13:19

  4. Oliver Klee commented on patch set 1 10/26/22, 13:20

    FileBackendTest.php:36

    Shouldn't that be in typo3temp? (I feel uncomfortable polluting the instance root with test data.)
  5. Stefan Bürk commented on patch set 1 10/26/22, 13:25

    FileBackendTest.php:36 Reply

    Does not really matter, has to be cleaned up anyway. BUt that whas the vfs con, no-one really cared. But ack, I think we should adjust the path here.
  6. Christian Kuhn commented on patch set 1 10/26/22, 13:28

    FileBackendTest.php:36 Reply

    does not matter since the path is removed in tearDown() anyways: switching to something else then needs assumptions or Environment usage to stay stable in case we switch functional tests to composer-based instances. So i decided to keep 'root' dir stuff for now.
  7. Stefan Bürk voted on patch set 1 V +2 CR +2 10/26/22, 13:29

  8. Stefan Bürk merged patch set 2 10/26/22, 13:29