Review main Merged

76296[TASK] Avoid testing 'non-writable' directory

Christian Kuhn CR +2 V +2 Easy +0 −42 updated 10/26/22, 13:46

Commit message

Testing 'non-writable' directories is flaky in
real life since it depends on the user that
executes these tests. On gitlab CI, it is useless
a-priori, since gitlab runs as root in containers.
Establishing a vfs for this does not help us much,
especially when it just tests if some exception is
thrown, which is done obviously when reading code.
This vfsStream usage is simply not worth the dependency.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/26/22, 13:36

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 10/26/22, 13:40

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 10/26/22, 13:40

  4. core-ci voted on patch set 1 V +1 10/26/22, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32805

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/26/22, 13:46

  6. Christian Kuhn merged patch set 2 10/26/22, 13:46