Review main Merged

76297[TASK] Avoid vfsStream in GeneralUtility tests

Christian Kuhn CR +2 V +2 Normal +40 −82 updated 10/26/22, 14:50

Commit message

We can avoid vfs usages in GeneralUtility
tests by creating fixture files and testing
these directly. A detail test for mtime is
skipped since this is rather obvious in the
test subject.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Christian Kuhn uploaded patch set 1 10/26/22, 14:38

  2. Anja Leichsenring updated the commit message in patch set 2 10/26/22, 14:39

  3. Anja Leichsenring voted on patch set 2 V +1 CR +1 10/26/22, 14:41

  4. core-ci voted on patch set 2 V +1 10/26/22, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32807

  5. Stefan Bürk voted on patch set 2 V +2 CR +2 10/26/22, 14:48

  6. Stefan Bürk merged patch set 3 10/26/22, 14:48

  7. core-ci voted on patch set 1 V +1 10/26/22, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32806