Review main Merged

76299[TASK] Simplify FAL related unit tests

Christian Kuhn CR +2 V +2 Hard +239 −229 updated 10/26/22, 16:50

Commit message

To finally tame the FAL related unit tests,
the resource related BaseTestCase is dissolved
and merged into consuming classes as first step.
This simplifies the construct and allows further
refactorings.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 89

  1. Christian Kuhn uploaded patch set 1 10/26/22, 16:07

  2. core-ci voted on patch set 1 V +1 10/26/22, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32811

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/26/22, 16:16

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 10/26/22, 16:18

  5. Oliver Klee voted on patch set 1 V +1 10/26/22, 16:19

  6. Stefan Bürk voted on patch set 1 V +2 CR +2 10/26/22, 16:21

  7. Stefan Bürk merged patch set 2 10/26/22, 16:22

  8. Oliver Klee commented on patch set 1 V +1 10/26/22, 16:22

    ResourceStorageTest.php:105

    @return Folder&MockObject

    ResourceStorageTest.php:117

    @return File&MockObject

    ResourceStorageTest.php:126

    @return (File|Folder)&MockObject … but we should drop this method in one of the next changes. It's really not clean.
  9. Oliver Klee commented on patch set 2 10/26/22, 16:50

    ResourceStorageTest.php:105 Reply

    ResourceStorageTest.php:117 Reply

    Done

    ResourceStorageTest.php:126 Reply

    Done