76299[TASK] Simplify FAL related unit tests
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Andreas Kienast +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 11
- Build/phpstan/phpstan-baseline.neon+10 −15
- typo3/sysext/core/Tests/Unit/Resource/Collection/FileCollectionRegistryTest.php+12 −2
- typo3/sysext/core/Tests/Unit/Resource/Driver/AbstractDriverTest.php+14 −2
- typo3/sysext/core/Tests/Unit/Resource/Driver/AbstractHierarchicalFilesystemDriverTest.php+13 −5
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+68 −18
- typo3/sysext/core/Tests/Unit/Resource/BaseTestCase.phpdeleted+0 −160
- typo3/sysext/core/Tests/Unit/Resource/RelativeCssPathFixerTest.php+18 −4
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorIntegrationTest.php+14 −5
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+13 −7
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php6+75 −9
- typo3/sysext/frontend/Tests/Unit/Typolink/LinkVarsCalculatorTest.php+2 −2
Review log 89
-
Christian Kuhn uploaded patch set 1 10/26/22, 16:07
-
core-ci voted on patch set 1 V +1 10/26/22, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32811
-
Stefan Bürk voted on patch set 1 V +1 CR +1 10/26/22, 16:16
-
Andreas Kienast voted on patch set 1 V +1 CR +1 10/26/22, 16:18
-
Oliver Klee voted on patch set 1 V +1 10/26/22, 16:19
-
Stefan Bürk voted on patch set 1 V +2 CR +2 10/26/22, 16:21
-
Stefan Bürk merged patch set 2 10/26/22, 16:22
-
Oliver Klee commented on patch set 1 V +1 10/26/22, 16:22
ResourceStorageTest.php:117@return File&MockObjectResourceStorageTest.php:126@return (File|Folder)&MockObject … but we should drop this method in one of the next changes. It's really not clean. -
Oliver Klee commented on patch set 2 10/26/22, 16:50
ResourceStorageTest.php:105ReplyAll fixed here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76300ResourceStorageTest.php:117ReplyDoneResourceStorageTest.php:126ReplyDone
ResourceStorageTest.php:105