Review 11.5 Merged

76302[BUGFIX] Ensure correct page-section cache identifier calculation

Stefan Bürk CR +2 V +2 Easy +10 −5 updated 12/05/22, 14:12

Commit message

Way back until early stage of v11 development the page section
cache entry included only the rootline of the default language
for the page. This changed with #23736, when language loading
has been moved more forward to allow language based matching
in TypoScript.

However, the used identifier for the section cache did not
include the language in any kind. Thus making the rootLine
flipping in the cache, and getting eventually a cache entry
with the wrong rootLine set. This also leads to a flipping
identifier for the page content cache identifier `newHash`.

This leads to the reported behaviour of regulary ignoring
the cache and rebuilding the page, also it should not have
been necessary.

This change extend the page-section cache identifier with
the language id. This means, that we now have one cache
entry per language, instead of a generic one as in the
good old days. Back than, one entry was enough as it has
always included only the default language rootline.

Better having dedicated cache entries per language than
a on-going rebuild of the cache which can take complete
down in a really bad way.

To avoid changing method signatures, the already existing
context is used in TemplateService to properly calculate
the cache identifier with the language id included.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Joey Bouten +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Meelis Karulin +1
    • Sybille Peters +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1827

Show 12 earlier messages
  1. Stefan Bürk uploaded patch set 1 10/27/22, 06:13

  2. core-ci voted on patch set 1 V +1 10/27/22, 06:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32823

  1. Stefan Bürk commented on patch set 1 11/28/22, 01:16

  2. Stefan Bürk uploaded patch set 2 V +1 11/28/22, 01:31

  3. core-ci voted on patch set 2 V +1 11/28/22, 01:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34295

  4. Stefan Bürk uploaded patch set 3 V +1 11/28/22, 01:41

  5. core-ci voted on patch set 3 V +1 11/28/22, 01:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34296

  6. Stefan Bürk uploaded patch set 4 V +1 11/28/22, 01:52

  7. core-ci voted on patch set 4 V +1 11/28/22, 02:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34297

  8. Stefan Bürk uploaded patch set 5 V +1 11/28/22, 21:14

  9. Stefan Bürk updated the commit message in patch set 6 11/28/22, 21:14

  10. core-ci voted on patch set 6 V -1 11/28/22, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34340

  11. core-ci voted on patch set 5 V -1 11/28/22, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34339

  12. Stefan Bürk uploaded patch set 7 V -1 11/28/22, 21:39

  13. Stefan Bürk uploaded patch set 8 11/28/22, 21:40

  14. Stefan Bürk updated the commit message in patch set 9 11/28/22, 21:40

  15. core-ci voted on patch set 9 V +1 11/28/22, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34343

  16. Stefan Bürk updated the commit message in patch set 10 V +1 11/29/22, 08:30

  17. core-ci voted on patch set 10 V +1 11/29/22, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34353

  18. Stefan Bürk uploaded patch set 11 V +1 12/02/22, 16:28

  19. core-ci voted on patch set 11 V +1 12/02/22, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34576

  20. Benni Mack voted on patch set 11 CR +1 12/05/22, 09:14

  21. Joey Bouten voted on patch set 11 CR +1 12/05/22, 10:10

  22. Sybille Peters commented on patch set 11 V +1 12/05/22, 11:11

    Just tested for now. Could reproduce problem and verify it is fixed 😊
  23. Meelis Karulin commented on patch set 11 V +1 12/05/22, 12:10

    Works!
  24. Stefan Bürk voted on patch set 11 V +2 CR +2 12/05/22, 14:12

  25. Stefan Bürk merged patch set 12 12/05/22, 14:12