Review main Merged

76304[TASK] Replace prophecy in EXT:extbase QueryTest

Torben Hansen CR +2 V +2 Easy +11 −36 updated 10/27/22, 11:05

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1316

  1. Torben Hansen uploaded patch set 1 10/27/22, 08:38

  2. core-ci voted on patch set 1 V +1 10/27/22, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32825

  3. Benni Mack voted on patch set 1 V +1 CR +1 10/27/22, 09:56

  4. Oliver Klee voted on patch set 1 V +1 10/27/22, 10:33

  5. Oliver Klee commented on patch set 1 CR -1 10/27/22, 10:37

    QueryTest.php:42

    This also needs to be an intersection type, not a union type: Query&MockObject&AccessibleObjectInterface
  6. Torben Hansen uploaded patch set 2 10/27/22, 10:39

  7. Torben Hansen commented on patch set 2 10/27/22, 10:40

    QueryTest.php:42 Reply

    Done
  8. Oliver Klee voted on patch set 2 CR +1 10/27/22, 10:46

  9. core-ci voted on patch set 2 V +1 10/27/22, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32833

  10. Andreas Kienast voted on patch set 2 V +1 CR +1 10/27/22, 10:52

  11. Stefan Bürk commented on patch set 3 10/27/22, 10:57

    Published edit on patch set 2.
  12. Nikita Hovratov voted on patch set 3 V +1 CR +1 10/27/22, 10:58

  13. Stefan Bürk voted on patch set 3 V +1 CR +1 10/27/22, 10:58

  14. core-ci voted on patch set 3 V +1 10/27/22, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32836

  15. Stefan Bürk voted on patch set 3 V +2 CR +2 10/27/22, 11:05

  16. Stefan Bürk merged patch set 4 10/27/22, 11:05