Review main Merged

76306[TASK] Replace prophecy in EXT:extbase QueryFactoryTest

Torben Hansen CR +2 V +2 Easy +5 −19 updated 10/27/22, 10:56

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Torben Hansen uploaded patch set 1 10/27/22, 08:47

  2. core-ci voted on patch set 1 V +1 10/27/22, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32827

  3. Benni Mack voted on patch set 1 V +1 CR +1 10/27/22, 09:41

  4. Oliver Klee voted on patch set 1 V +1 10/27/22, 10:34

  5. Oliver Klee commented on patch set 1 CR -1 10/27/22, 10:35

    QueryFactoryTest.php:42

    This needs to be DataMap&MockObject. (In general, mocks always are an intersection type of the original type and MockObject. And yes, I know that many of the existing annotations are incorrect in that regard.) Ditto for $dataMapFactory.
  6. Torben Hansen uploaded patch set 2 10/27/22, 10:38

  7. Torben Hansen commented on patch set 1 10/27/22, 10:38

    QueryFactoryTest.php:42 Reply

    Done
  8. Oliver Klee voted on patch set 2 CR +1 10/27/22, 10:46

  9. core-ci voted on patch set 2 V +1 10/27/22, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32832

  10. Andreas Kienast voted on patch set 2 V +1 CR +1 10/27/22, 10:53

  11. Stefan Bürk voted on patch set 2 V +2 CR +2 10/27/22, 10:55

  12. Stefan Bürk merged patch set 3 10/27/22, 10:56