Review main Merged

76309[TASK] Improve FAL tests

Christian Kuhn CR +2 V +2 Nightmare +2390 −3676 updated 10/27/22, 16:20

Commit message

* Make some unit tests functional test
* Remove some state
* Avoid last usages of vfsStream

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 37

Show 17 more files

Review log 711

  1. Christian Kuhn uploaded patch set 1 10/27/22, 09:22

  2. core-ci voted on patch set 1 V +1 10/27/22, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32830

  3. Christian Kuhn uploaded patch set 2 10/27/22, 13:45

  4. core-ci voted on patch set 2 V -1 10/27/22, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32843

  5. Christian Kuhn uploaded patch set 3 10/27/22, 15:57

  6. Christian Kuhn updated the commit message in patch set 4 10/27/22, 16:01

  7. core-ci voted on patch set 4 V +1 10/27/22, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32848

  8. core-ci voted on patch set 3 V +1 10/27/22, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32847

  9. Anja Leichsenring voted on patch set 4 V +1 CR +1 10/27/22, 16:11

  10. Stefan Bürk voted on patch set 4 V +2 CR +2 10/27/22, 16:20

  11. Stefan Bürk merged patch set 5 10/27/22, 16:20