Review main Merged

76310[BUGFIX] Make toolbar dropdown menu scrollable again

Oli Bartsch CR +2 V +2 Easy +2 −1 updated 10/27/22, 19:12

Commit message

With #94641 toolbar dropdown menus were made
scrollable, since otherwise bookmarks were cut off
at the bottom of the screen.

With #98307 the corresponding "max-height" option
was removed, leading to the same bug as before. This
is now fixed by adding the option again.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 68

  1. Oli Bartsch uploaded patch set 1 10/27/22, 10:16

  2. core-ci voted on patch set 1 V -1 10/27/22, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32831

  3. Oli Bartsch uploaded patch set 2 10/27/22, 11:24

  4. core-ci voted on patch set 2 V +1 10/27/22, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32837

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 10/27/22, 13:06

  6. Benni Mack voted on patch set 2 V +1 CR +1 10/27/22, 14:46

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 10/27/22, 19:12

  8. Oli Bartsch merged patch set 3 10/27/22, 19:12