Review main Merged

76313[TASK] Replace prophecy in EXT:frontend DatabaseRecordLinkBuilderTest

Nikita Hovratov CR +2 V +2 Normal +22 −29 updated 10/27/22, 18:06

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Nikita Hovratov uploaded patch set 1 10/27/22, 15:01

  2. core-ci voted on patch set 1 V +1 10/27/22, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32845

  3. Oliver Klee commented on patch set 1 CR -1 10/27/22, 16:13

    DatabaseRecordLinkBuilderTest.php:174

    Please let's have the method call argument first, then the return value, so the order in the source code matches the order in which things happen.
  4. Oliver Klee commented on patch set 2 10/27/22, 17:56

    Published edit on patch set 1.
  5. Oliver Klee commented on patch set 2 CR +1 10/27/22, 17:57

    DatabaseRecordLinkBuilderTest.php:174 Reply

    Done
  6. Stefan Bürk voted on patch set 2 V +1 CR +1 10/27/22, 18:01

  7. core-ci voted on patch set 2 V +1 10/27/22, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32856

  8. Oliver Klee voted on patch set 2 V +1 10/27/22, 18:05

  9. Stefan Bürk voted on patch set 2 V +2 CR +2 10/27/22, 18:06

  10. Stefan Bürk merged patch set 3 10/27/22, 18:06