Review main Merged

76318[TASK] Update phpstan-phpunit to 1.2.2

Wouter Wolters CR +2 V +2 Easy +9 −9 updated 10/29/22, 12:58

Commit message

composer req --dev phpstan/phpstan-phpunit:^1.2.2
Resolves: #98943
Releases: main, 11.5

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Files 2

Review log 912

  1. Wouter Wolters uploaded patch set 1 10/27/22, 19:18

  2. core-ci voted on patch set 1 V +1 10/27/22, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32857

  3. Oliver Klee updated the commit message in patch set 2 10/27/22, 19:49

  4. Oliver Klee voted on patch set 2 V +1 CR +1 10/27/22, 19:50

  5. core-ci voted on patch set 2 V +1 10/27/22, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32858

  6. Oliver Klee commented on patch set 2 CR -1 10/28/22, 12:26

    In the meantime, version 1.2.2 has been released, and we should directly update to that version.
  7. Wouter Wolters uploaded patch set 3 10/28/22, 17:32

  8. Oliver Klee voted on patch set 3 CR +1 10/28/22, 17:35

  9. core-ci voted on patch set 3 V +1 10/28/22, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32874

  10. Oliver Klee voted on patch set 3 V +1 10/28/22, 17:58

  11. Stefan Bürk voted on patch set 3 V +2 CR +2 10/29/22, 12:58

  12. Stefan Bürk merged patch set 4 10/29/22, 12:58