Review main Merged

76320[TASK] Remove useCrawlerForExternalFiles setting from Indexed Search

Tomas Norre Mikkelsen CR +2 V +2 Easy +0 −6 updated 10/28/22, 18:51

Commit message

This removes an obsolete configuration from the Indexed Search.
It was earlier used to use the TYPO3 Crawler for indexing
external files. As the TYPO3 Crawler isn't used anymore
as a direct dependency of Indexed Search this can be removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Tomas Norre Mikkelsen uploaded patch set 1 10/28/22, 08:36

  2. Tomas Norre Mikkelsen updated the commit message in patch set 2 10/28/22, 08:43

  3. core-ci voted on patch set 1 V +1 10/28/22, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32867

  4. core-ci voted on patch set 2 V +1 10/28/22, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32868

  5. Benni Mack commented on patch set 2 10/28/22, 09:15

    you can also remove the label key (as mentioned in the ext_conf_template.txt)
  6. Tomas Norre Mikkelsen uploaded patch set 3 10/28/22, 10:02

  7. core-ci voted on patch set 3 V +1 10/28/22, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32870

  8. Tomas Norre Mikkelsen commented on patch set 3 10/28/22, 10:28

    Reply

    Done. I read it wrong in the first place, so that's why i didn't removed it. But it's gone now.
  9. Stefan Bürk voted on patch set 3 V +1 CR +1 10/28/22, 15:19

  10. Benni Mack voted on patch set 3 V +2 CR +2 10/28/22, 18:51

  11. Benni Mack merged patch set 4 10/28/22, 18:51