Review main Merged

76324[TASK] Replace prophecy in ConditionMatcherTest

Nikita Hovratov CR +2 V +2 Easy +5 −24 updated 10/29/22, 12:48

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1014

  1. Nikita Hovratov uploaded patch set 1 10/29/22, 09:44

  2. core-ci voted on patch set 1 V +1 10/29/22, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32884

  3. Oliver Klee commented on patch set 1 10/29/22, 10:32

    ConditionMatcherTest.php:435

    Instead of a mocked logger, we can also use the `NullLogger` instead.
  4. Nikita Hovratov uploaded patch set 2 10/29/22, 12:10

  5. Nikita Hovratov commented on patch set 2 10/29/22, 12:11

    ConditionMatcherTest.php:435 Reply

    Thanks for the hint!
  6. core-ci voted on patch set 2 V -1 10/29/22, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32891

  7. Nikita Hovratov uploaded patch set 3 10/29/22, 12:25

  8. Stefan Bürk commented on patch set 4 10/29/22, 12:31

    Published edit on patch set 3.
  9. core-ci voted on patch set 3 V +1 10/29/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32892

  10. Stefan Bürk voted on patch set 4 V +1 CR +1 10/29/22, 12:38

  11. core-ci voted on patch set 4 V +1 10/29/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32893

  12. Oliver Klee voted on patch set 4 V +1 CR +1 10/29/22, 12:43

  13. Stefan Bürk voted on patch set 4 V +2 CR +2 10/29/22, 12:48

  14. Stefan Bürk merged patch set 5 10/29/22, 12:48