Review main Merged

7633[BUGFIX] TCEmain::clear_cacheCmd relies on active BE_USER

Steffen Gebert CR +2 V +2 Easy +3 −1 updated 06/03/13, 20:49

Commit message

Several developers abuse t3lib_TCEmain and instantiate it also in other
contexts than BE, for which it never was made.

As this breaks several extensions that use it in FE or CLI mode and the
fix is trivial, avoid crashing.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Georg Ringer +1
    • Philipp Gampe +1

Files 1

Review log 6

  1. Tolleiv Nietsch commented on patch set 1 V 0 01/15/12, 16:01

    by team member; Looks good to me, approved
  2. Georg Ringer commented on patch set 1 01/15/12, 16:01

    Verified; Looks good to me, but someone else must approve
  3. Philipp Gampe commented on patch set 1 01/15/12, 16:01

    Verified; Looks good to me, but someone else must approve Works fine.
  4. Mr. Jenkins commented on patch set 1 01/15/12, 16:01

  5. Wouter Wolters commented on patch set 1 01/15/12, 16:01

    Looks good to me, but someone else must approve
  6. Tolleiv Nietsch merged patch set 1 01/15/12, 16:01