Review main Merged

76332[TASK] Remove the comment "Test case" from test files

Nikita Hovratov CR +2 V +2 Hard +0 −967 updated 10/29/22, 16:34

Commit message

These comments don't add any value as the class under test can be easily
determined from the filename.

Executed commands:

> grep -Rn -E "^\s\*\sTest case(\sfor.*|\.)?$" --include="*Test\.php" \
typo3/sysext/ | awk -F':' '{print "sed -i \047" $2-1 "," $2+1 "d\047 " $1}' | sh

Some files with more comments needed manual adaption.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Chris Müller +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Chris Müller +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 326

Show 306 more files

Review log 79

  1. Nikita Hovratov uploaded patch set 1 10/29/22, 15:19

  2. core-ci voted on patch set 1 V -1 10/29/22, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32897

  3. Nikita Hovratov uploaded patch set 2 10/29/22, 15:33

  4. core-ci voted on patch set 2 V +1 10/29/22, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32898

  5. Chris Müller voted on patch set 2 V +1 CR +1 10/29/22, 15:56

  6. Oliver Klee voted on patch set 2 V +1 10/29/22, 16:10

  7. Oliver Klee voted on patch set 2 CR +1 10/29/22, 16:32

  8. Georg Ringer voted on patch set 2 V +2 CR +2 10/29/22, 16:34

  9. Georg Ringer merged patch set 3 10/29/22, 16:34