Review main Merged

76334[TASK] Replace prophecy in EXT:core Typo3DatabaseBackendTest

Nikita Hovratov CR +2 V +2 Normal +50 −56 updated 10/30/22, 13:39

Commit message

Also, a wrong call to flushByTag(s) is corrected.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Nikita Hovratov uploaded patch set 1 10/29/22, 22:45

  2. core-ci voted on patch set 1 V -1 10/29/22, 22:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32900

  3. Nikita Hovratov uploaded patch set 2 10/29/22, 23:03

  4. core-ci voted on patch set 2 V +1 10/29/22, 23:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32902

  5. Oliver Klee voted on patch set 2 V +1 10/30/22, 08:22

  6. Oliver Klee voted on patch set 2 CR +1 10/30/22, 08:23

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 10/30/22, 13:39

  8. Stefan Bürk merged patch set 3 10/30/22, 13:39