Review main Merged

76337[FEATURE] Respect write-protected settings.php in Install Tool

Andreas Kienast CR +2 V +2 Hard +319 −153 updated 11/03/22, 20:41

Commit message

The "System" section in the Install Tool now informs a system
maintainer if the file `system/settings.php` is write-protected by
rendering an info box in the main module and each submodule.
Additionally, all input fields are disabled and submit buttons are
removed.

This allows to make the settings file read-only after deployments.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Markus Klein +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 32

Show 12 more files

Review log 1115

  1. Andreas Kienast uploaded patch set 1 10/30/22, 12:12

  2. Andreas Kienast uploaded patch set 2 10/30/22, 12:13

  3. core-ci voted on patch set 1 V -1 10/30/22, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32909

  4. core-ci voted on patch set 2 V +1 10/30/22, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32910

  5. Andreas Kienast uploaded patch set 3 10/30/22, 12:25

  6. core-ci voted on patch set 3 V +1 10/30/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32911

  7. Andreas Kienast commented on patch set 3 CR -1 10/30/22, 18:55

    LocalConfigurationValueService.php:221

    Method is unused
  8. Andreas Kienast commented on patch set 4 10/30/22, 20:21

    Published edit on patch set 3.
  9. core-ci voted on patch set 4 V +1 10/30/22, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32924

  10. Andreas Kienast commented on patch set 4 10/31/22, 08:51

    LocalConfigurationValueService.php:221 Reply

    Done
  11. Oliver Hader commented on patch set 4 10/31/22, 10:14

    I like the improved security impact in general, however™... * instead of handling a particular file, we should try to get rid of `ext:install` on production websites → `ext:install` would be dev-dependency in the future * (side note: next to `settings.php` there are e.g. site configuration files that might benefit from the read only behavior as well)
  12. Andreas Kienast commented on patch set 4 10/31/22, 11:52

    Reply

    Stefan Bürk had the same idea with site configuration files. If this patch is good to go, I can prepare the same for the sites management module.
  13. Markus Klein commented on patch set 4 V +1 CR +1 11/02/22, 15:28

    works, but of course Core fails hard, if the settings.php file is not writable and silent migrations have to be done
  14. Stefan Bürk voted on patch set 4 V +2 CR +2 11/03/22, 20:41

  15. Stefan Bürk merged patch set 5 11/03/22, 20:41