76337[FEATURE] Respect write-protected settings.php in Install Tool
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Markus Klein +1
-
Verified V +2 Done
- Stefan Bürk +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 32
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-98957-RespectWrite-protectedSettingsphpInInstallTool.rstnew+28 −0
- typo3/sysext/install/Classes/Controller/SettingsController.php+216 −138
- typo3/sysext/install/Classes/ServiceProvider.php+2 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/ExtensionConfiguration/ExtensionForm.html+11 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/LocalConfiguration/SubSection.html+6 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Cache/Custom.html+2 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Cache/Database.html+1 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Cache/File.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Context/Custom.html+2 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Context/Debug.html+1 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Context/Live.html+1 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Image/Custom.html+2 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Image/GraphicsMagick.html+1 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Image/ImageMagick6.html+1 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Mail/Custom.html+2 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Mail/Sendmail.html+1 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Mail/Smtp.html+1 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing/Argon2i.html+1 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing/Argon2id.html+1 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing/Bcrypt.html+1 −1
Show 12 more files
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing/Custom.html+1 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing/Pbkdf2.html+1 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing/Phpass.html+1 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Image.html+2 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/ConfigurationNotWritable.htmlnew+12 −0
- typo3/sysext/install/Resources/Private/Templates/Settings/Cards.html+2 −0
- typo3/sysext/install/Resources/Private/Templates/Settings/ChangeInstallToolPassword.html+4 −0
- typo3/sysext/install/Resources/Private/Templates/Settings/ExtensionConfigurationGetContent.html+2 −0
- typo3/sysext/install/Resources/Private/Templates/Settings/FeaturesGetContent.html+4 −0
- typo3/sysext/install/Resources/Private/Templates/Settings/LocalConfigurationGetContent.html+2 −0
- typo3/sysext/install/Resources/Private/Templates/Settings/PresetsGetContent.html+2 −0
- typo3/sysext/install/Resources/Private/Templates/Settings/SystemMaintainer.html+3 −0
Review log 1115
-
Andreas Kienast uploaded patch set 1 10/30/22, 12:12
-
Andreas Kienast uploaded patch set 2 10/30/22, 12:13
-
core-ci voted on patch set 1 V -1 10/30/22, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32909
-
core-ci voted on patch set 2 V +1 10/30/22, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32910
-
Andreas Kienast uploaded patch set 3 10/30/22, 12:25
-
core-ci voted on patch set 3 V +1 10/30/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32911
-
Andreas Kienast commented on patch set 3 CR -1 10/30/22, 18:55
-
Andreas Kienast commented on patch set 4 10/30/22, 20:21
Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 10/30/22, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32924
-
Andreas Kienast commented on patch set 4 10/31/22, 08:51
LocalConfigurationValueService.php:221ReplyDone -
Oliver Hader commented on patch set 4 10/31/22, 10:14
I like the improved security impact in general, however™... * instead of handling a particular file, we should try to get rid of `ext:install` on production websites → `ext:install` would be dev-dependency in the future * (side note: next to `settings.php` there are e.g. site configuration files that might benefit from the read only behavior as well) -
Andreas Kienast commented on patch set 4 10/31/22, 11:52
Reply
Stefan Bürk had the same idea with site configuration files. If this patch is good to go, I can prepare the same for the sites management module. -
Markus Klein commented on patch set 4 V +1 CR +1 11/02/22, 15:28
works, but of course Core fails hard, if the settings.php file is not writable and silent migrations have to be done -
Stefan Bürk voted on patch set 4 V +2 CR +2 11/03/22, 20:41
-
Stefan Bürk merged patch set 5 11/03/22, 20:41
LocalConfigurationValueService.php:221