Review main Merged

76338[TASK] Replace prophecy in EXT:extensionmanager ExtensionStatusTest

Torben Hansen CR +2 V +2 Normal +107 −109 updated 10/30/22, 18:45

Commit message

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1720

  1. Torben Hansen uploaded patch set 1 10/30/22, 13:11

  2. core-ci voted on patch set 1 V -1 10/30/22, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32912

  3. Torben Hansen uploaded patch set 2 10/30/22, 13:31

  4. core-ci voted on patch set 2 V +1 10/30/22, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32914

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 10/30/22, 13:43

  6. Oliver Klee voted on patch set 2 V +1 10/30/22, 13:44

  7. Oliver Klee commented on patch set 2 CR -1 10/30/22, 13:45

    ExtensionStatusTest.php:102

    The name is wrong - this is not prophecy anymore.

    ExtensionStatusTest.php:120

    Ditto.
  8. Torben Hansen uploaded patch set 3 10/30/22, 13:48

  9. Torben Hansen commented on patch set 3 10/30/22, 13:48

    ExtensionStatusTest.php:102 Reply

    Done
  10. Oliver Klee commented on patch set 3 10/30/22, 13:52

    ExtensionStatusTest.php:108

    This assertion is new. Is this a copy'n'paste error?

    ExtensionStatusTest.php:116

    This assertion is missing from the new test now.
  11. core-ci voted on patch set 3 V +1 10/30/22, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32917

  12. Oliver Klee voted on patch set 3 V +1 10/30/22, 14:06

  13. Oliver Klee voted on patch set 3 V 0 10/30/22, 14:06

  14. Stefan Bürk commented on patch set 3 10/30/22, 14:13

    ExtensionStatusTest.php:116 Reply

    Nopte, it's not missing. ``` $remoteRegistryMock->expects(self::atLeastOnce())->method('hasDefaultRemote'); ```
  15. Oliver Klee commented on patch set 3 10/30/22, 14:30

    ExtensionStatusTest.php:116 Reply

    Ack.
  16. Torben Hansen commented on patch set 3 10/30/22, 17:09

    ExtensionStatusTest.php:108 Reply

    No, this is by intention. Since the original setUpRegistryStatusTests() function already contained an method matcher for `getDefaultRemote`, it was not possible to override this in getStatusReturnsNoticeIfRepositoryUpdateIsLongerThanSevenDaysAgo() test. Therefore I removed the method matcher for `getDefaultRemote` from setUpRegistryStatusTests() and added the expected return after the mock object has been fetched in each test.
  17. Nikita Hovratov commented on patch set 3 V +1 CR +1 10/30/22, 18:17

    ExtensionStatusTest.php:120 Reply

    Done
  18. Oliver Klee voted on patch set 3 V +1 CR +1 10/30/22, 18:44

  19. Nikita Hovratov voted on patch set 3 V +2 CR +2 10/30/22, 18:45

  20. Nikita Hovratov merged patch set 4 10/30/22, 18:45