76338[TASK] Replace prophecy in EXT:extensionmanager ExtensionStatusTest
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1720
-
Torben Hansen uploaded patch set 1 10/30/22, 13:11
-
core-ci voted on patch set 1 V -1 10/30/22, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32912
-
Torben Hansen uploaded patch set 2 10/30/22, 13:31
-
core-ci voted on patch set 2 V +1 10/30/22, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32914
-
Stefan Bürk voted on patch set 2 V +1 CR +1 10/30/22, 13:43
-
Oliver Klee voted on patch set 2 V +1 10/30/22, 13:44
-
Oliver Klee commented on patch set 2 CR -1 10/30/22, 13:45
ExtensionStatusTest.php:120Ditto. -
Torben Hansen uploaded patch set 3 10/30/22, 13:48
-
Torben Hansen commented on patch set 3 10/30/22, 13:48
ExtensionStatusTest.php:102ReplyDone -
Oliver Klee commented on patch set 3 10/30/22, 13:52
ExtensionStatusTest.php:108This assertion is new. Is this a copy'n'paste error?ExtensionStatusTest.php:116This assertion is missing from the new test now. -
core-ci voted on patch set 3 V +1 10/30/22, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32917
-
Oliver Klee voted on patch set 3 V +1 10/30/22, 14:06
-
Oliver Klee voted on patch set 3 V 0 10/30/22, 14:06
-
Stefan Bürk commented on patch set 3 10/30/22, 14:13
ExtensionStatusTest.php:116ReplyNopte, it's not missing. ``` $remoteRegistryMock->expects(self::atLeastOnce())->method('hasDefaultRemote'); ``` -
Oliver Klee commented on patch set 3 10/30/22, 14:30
ExtensionStatusTest.php:116ReplyAck. -
Torben Hansen commented on patch set 3 10/30/22, 17:09
ExtensionStatusTest.php:108ReplyNo, this is by intention. Since the original setUpRegistryStatusTests() function already contained an method matcher for `getDefaultRemote`, it was not possible to override this in getStatusReturnsNoticeIfRepositoryUpdateIsLongerThanSevenDaysAgo() test. Therefore I removed the method matcher for `getDefaultRemote` from setUpRegistryStatusTests() and added the expected return after the mock object has been fetched in each test. -
Nikita Hovratov commented on patch set 3 V +1 CR +1 10/30/22, 18:17
ExtensionStatusTest.php:120ReplyDone -
Oliver Klee voted on patch set 3 V +1 CR +1 10/30/22, 18:44
-
Nikita Hovratov voted on patch set 3 V +2 CR +2 10/30/22, 18:45
-
Nikita Hovratov merged patch set 4 10/30/22, 18:45
ExtensionStatusTest.php:102