Review main Merged

76339[TASK] Replace prophecy in EXT:extensionmanager DependencyUtilityTest

Torben Hansen CR +2 V +2 Easy +3 −9 updated 10/30/22, 14:14

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Torben Hansen uploaded patch set 1 10/30/22, 13:40

  2. Oliver Klee voted on patch set 1 CR +1 10/30/22, 13:45

  3. Stefan Bürk commented on patch set 1 10/30/22, 13:47

    DependencyUtilityTest.php:238

    We can use the already introduced \TYPO3\CMS\Core\Tests\Unit\Fixtures\EventDispatcher\NoopEventDispatcher test class instead of a mock here.

    DependencyUtilityTest.php:260

    NoopEventDispatcher
  4. core-ci voted on patch set 1 V +1 10/30/22, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32915

  5. Torben Hansen uploaded patch set 2 10/30/22, 13:52

  6. Torben Hansen commented on patch set 1 10/30/22, 13:53

    DependencyUtilityTest.php:238 Reply

    Good catch. I did not know NoopEventDispatcher yet.

    DependencyUtilityTest.php:260 Reply

    Done
  7. core-ci voted on patch set 2 V +1 10/30/22, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32918

  8. Oliver Klee voted on patch set 2 V +1 CR +1 10/30/22, 14:07

  9. Stefan Bürk voted on patch set 2 V +2 CR +2 10/30/22, 14:14

  10. Stefan Bürk merged patch set 3 10/30/22, 14:14