7634[TASK] Rebuild t3lib/core_autoload.php
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Oliver Klee +1
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Tolleiv Nietsch +2
- Philipp Gampe +1
Files 1
Review log 14
-
Markus Klein commented on patch set 1 01/13/12, 00:48
(1 inline comment)Releases line missing? (or left out by intention?) -
Tolleiv Nietsch commented on patch set 2 V 0 01/13/12, 00:48
by team member; Looks good to me, approved -
Markus Klein uploaded patch set 2 01/13/12, 00:48
-
Oliver Klee commented on patch set 2 01/13/12, 00:48
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 2 01/13/12, 00:48
This is the same as https://review.typo3.org/#change,7701 , I think. -
Philipp Gampe commented on patch set 1 01/13/12, 00:48
No score; No score You should create an issue for this. That way other issue can be related to this one (for example #32744). tip for other reviewers: ignore moved lines https://gist.github.com/1202342 usage: git diff -w HEAD^ | ignore_moves.py |sort -f -k 2 -
Philipp Gampe commented on patch set 1 01/13/12, 00:48
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 1 01/13/12, 00:48
Verified; Looks good to me, but someone else must approve Fixes missing classes. Tested with #32744. -
Philipp Gampe commented on patch set 2 01/13/12, 00:48
Verified; Looks good to me, but someone else must approve Reapply vote ... no changes in patch. -
Mr. Jenkins commented on patch set 1 01/13/12, 00:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2881/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/13/12, 00:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2929/ : SUCCESS -
Wouter Wolters commented on patch set 1 01/13/12, 00:48
Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 2 01/13/12, 00:48
Looks good to me, but someone else must approve -
Tolleiv Nietsch merged patch set 2 01/13/12, 00:48