Review main Merged

76352[BUGFIX] Make search by ID filter in pagetree work with modified records

Benni Mack CR +2 V +2 Normal +111 −11 updated 11/04/22, 16:23

Commit message

The "filter by Page ID" functionality
within the page tree now also checks
for the live ID ("t3ver_oid") if a page
was modified.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1418

  1. Benni Mack uploaded patch set 1 10/31/22, 16:23

  2. core-ci voted on patch set 1 V +1 10/31/22, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32945

  3. Oliver Hader commented on patch set 1 CR +1 11/02/22, 12:44

    PageTreeRepository.php:573

    I was thinking about filtering placeholders via `t3ver_state`, but I think it's fine, since one also wants to see those changes...
  4. Danilo Caccialanza commented on patch set 1 V -1 11/02/22, 12:57

    Patch applied manually on v 12.0.0 and v11.5.17 When i use page filter: Page tree error Got unexpected response from the server. Please check logs for details. Core: Exception handler (WEB): Uncaught TYPO3 Exception: Undefined constant Doctrine\DBAL\Connection::PARAM_INT | Error thrown in file C:\wamp\www\base12\typo3\sysext\backend\Classes\Tree\Repository\PageTreeRepository.php in line 541. Requested URL: http://base12:8080/typo3/ajax/page/tree/filterData?token=--AnonymizedToken--&q=6
  5. Oliver Hader commented on patch set 1 11/02/22, 13:23

    Reply

    Danilo, it seems you picked the change to TYPO3 v12.0.0. Can you try again with latest version from Git `main` branch? Thx!
  6. Danilo Caccialanza commented on patch set 1 V 0 11/02/22, 18:36

    Reply

    Okay, it will be a little more complicated for me but I try.
  7. Benni Mack commented on patch set 1 11/02/22, 21:44

    Hey Danilo, I will add some functional tests as well, then create a backport to test this against 11.5
  8. Benni Mack uploaded patch set 2 11/02/22, 22:58

  9. Benni Mack uploaded patch set 3 11/02/22, 22:59

  10. Benni Mack uploaded patch set 4 11/02/22, 23:03

  11. Benni Mack commented on patch set 4 11/02/22, 23:04

    @danilo: backport is available here https://review.typo3.org/c/Packages/TYPO3.CMS/+/76412
  12. core-ci voted on patch set 4 V +1 11/02/22, 23:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33012

  13. core-ci voted on patch set 2 V +1 11/02/22, 23:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33007

  14. core-ci voted on patch set 3 V -1 11/02/22, 23:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33009

  15. Benni Mack commented on patch set 4 11/03/22, 10:13

    PageTreeRepository.php:573 Reply

    Done
  16. Christian Kuhn voted on patch set 4 V +1 CR +1 11/03/22, 11:08

  17. Oli Bartsch voted on patch set 4 V +2 CR +2 11/04/22, 16:23

  18. Oli Bartsch merged patch set 5 11/04/22, 16:23