Review main Merged

76353[TASK] Replace prophecy in EXT:core AbstractRepositoryTest

Nikita Hovratov CR +2 V +2 Normal +23 −35 updated 11/02/22, 08:47

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Nikita Hovratov uploaded patch set 1 10/31/22, 16:32

  2. core-ci voted on patch set 1 V +1 10/31/22, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32946

  3. Oliver Klee voted on patch set 1 V +1 10/31/22, 17:21

  4. Oliver Klee voted on patch set 1 CR +1 10/31/22, 17:22

  5. Stefan Bürk commented on patch set 1 11/01/22, 21:38

    This does not make much sense as unit test --- should either be migrated to a functional test or dropped. Mocking the whole stuff will only return the "mocked" thing and not ensuring that a string argument is fully supported at all ... Or am I wrong ?
  6. Stefan Bürk commented on patch set 1 V +1 CR +1 11/02/22, 08:17

    Reply

    Done
  7. Stefan Bürk voted on patch set 1 V +2 CR +2 11/02/22, 08:17

  8. Stefan Bürk merged patch set 2 11/02/22, 08:17

  9. Oliver Klee commented on patch set 2 11/02/22, 08:47

    Reply

    Just to put on my "unit testing workshop teacher hat" and give my 2¢. :-) Yes, at least the second test should be converted to a functional tests. (The first test for the exception I find okay as a unit test.) However, that should happen in a separate change as this change is only to get rid of Prophecy, and hence keeping this as a unit test in this change is fine. ("one thing at a time")