Review main Merged

76387[TASK] Clean FormProtectionFactory state in BackendUserAuthenticationTest

Christian Kuhn CR +2 V +2 Easy +6 −3 updated 11/02/22, 15:44

Commit message

This triggers fails when this unit tests is
executed *before* FormProtectionFactoryTests
in random-order unit test runs.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1012

  1. Christian Kuhn uploaded patch set 1 11/02/22, 15:31

  2. Oliver Klee commented on patch set 1 CR -1 11/02/22, 15:35

    The Releases line is missing.
  3. Stefan Bürk commented on patch set 1 V +1 CR +1 11/02/22, 15:35

    If applied, green with: ``` Build/Scripts/runTests.sh -s unitRandom -p 8.2 -o 1667401258 ``` without it red.
  4. Christian Kuhn updated the commit message in patch set 2 11/02/22, 15:36

  5. Stefan Bürk voted on patch set 1 V 0 CR 0 11/02/22, 15:36

  6. Christian Kuhn commented on patch set 2 11/02/22, 15:36

    Reply

    Done
  7. Stefan Bürk voted on patch set 2 V +1 CR +1 11/02/22, 15:37

  8. core-ci voted on patch set 1 V +1 11/02/22, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32993

  9. Oliver Klee voted on patch set 2 CR +1 11/02/22, 15:41

  10. core-ci voted on patch set 2 V +1 11/02/22, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32994

  11. Christian Kuhn voted on patch set 2 V +2 CR +2 11/02/22, 15:44

  12. Christian Kuhn merged patch set 3 11/02/22, 15:44