Review main Merged

7639[TASK] User settings: move flashMessage notice

Felix Kopp CR +2 V +2 Easy +12 −9 updated 06/03/13, 20:49

Commit message

There is a permanent flashMessage in user settings module to indicate
the possible necessity to reload the whole backend after changing
settings.
Move the reload notice in user settings module to the top and display
it only after saving.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Steffen Ritter +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Steffen Ritter +2
    • Wouter Wolters +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 24

  1. Steffen Ritter commented on patch set 1 01/17/12, 07:40

    Hi Felix, this change is "correct" from Syntax point of view. But that's all I currently can tell.. Mind to have an little bit more elaborated Commit-Message. To me it is totally unclear what happens. And I bet in half a year no one could figure out just from the entry within the git log. Furthermore it looks like you are just moving Code. Therefore if the functionality had been there, but just did not work it appears to be a Bugfix to me. Thanks for your clarification
  2. Philipp Gampe commented on patch set 1 01/17/12, 07:40

    Verified; Looks good to me, but someone else must approve

    index.php:415 Reply

    This can not happen, because you can not click both buttons at the same time. One is of type submit and the other is just type button.

    index.php:415 Reply

    Also ich sehe immer zwei: 1. OK und 2. Info wegen reload. Ist das also aus deiner Sicht OK?
  3. Markus Klein commented on patch set 3 01/17/12, 07:40

    (1 inline comment)
  4. Oliver Klee commented on patch set 3 01/17/12, 07:40

    (1 inline comment)

    index.php:415

    Won't this create two flash messages if $this->setupIsUpdated AND $this->settingsAreResetToDefault?
  5. Oliver Klee commented on patch set 3 01/17/12, 07:40

    (1 inline comment)
  6. Georg Ringer commented on patch set 3 01/17/12, 07:40

    Looks good to me, but someone else must approve
  7. Philipp Gampe uploaded patch set 3 01/17/12, 07:40

  8. Philipp Gampe commented on patch set 3 01/17/12, 07:40

    (1 inline comment)
  9. Philipp Gampe commented on patch set 3 01/17/12, 07:40

    (1 inline comment)
  10. Philipp Gampe commented on patch set 3 01/17/12, 07:40

    Verified; Looks good to me, but someone else must approve I just changed the commit message a bit.
  11. Tolleiv Nietsch commented on patch set 4 V 0 01/17/12, 07:40

    by team member; Looks good to me, approved
  12. Oliver Klee commented on patch set 4 01/17/12, 07:40

    Looks good to me, but someone else must approve
  13. Steffen Ritter commented on patch set 4 V 0 01/17/12, 07:40

    by team member; Looks good to me, approved
  14. Philipp Gampe uploaded patch set 4 01/17/12, 07:40

  15. Philipp Gampe commented on patch set 4 01/17/12, 07:40

    Verified; Looks good to me, but someone else must approve Fix for commit message.
  16. Felix Kopp commented on patch set 2 01/17/12, 07:40

    Only changes the commit message. That you for you input, Steffen. Hope that this new description makes it easy to follow my thoughts and thus more ideas can make it into the core. This could be considered a usability bugfix but also a feature. Actually the view without before saving is improved.
  17. Felix Kopp uploaded patch set 2 01/17/12, 07:40

  18. Mr. Jenkins commented on patch set 1 01/17/12, 07:40

  19. Mr. Jenkins commented on patch set 2 01/17/12, 07:40

  20. Mr. Jenkins commented on patch set 3 01/17/12, 07:40

  21. Mr. Jenkins commented on patch set 4 01/17/12, 07:40

  22. Wouter Wolters commented on patch set 3 01/17/12, 07:40

    Verified; Looks good to me, but someone else must approve
  23. Wouter Wolters commented on patch set 4 01/17/12, 07:40

    Verified; Looks good to me, but someone else must approve
  24. Steffen Ritter merged patch set 4 01/17/12, 07:40