76390[TASK] Replace prophecy in EXT:core PasswordHashFactoryTest
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1416
-
Nikita Hovratov uploaded patch set 1 11/02/22, 17:21
-
core-ci voted on patch set 1 V +1 11/02/22, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32999
-
Oliver Klee commented on patch set 1 CR -1 11/02/22, 17:36
PasswordHashFactoryTest.php:221Ditto. -
Christian Kuhn commented on patch set 1 11/02/22, 17:47
PasswordHashFactoryTest.php:88Replyi don't agree: the test-goal is achieved by testing for the exception already?!PasswordHashFactoryTest.php:221Replyi don't agree: the test-goal is achieved by testing for the exception already?! -
Oliver Klee commented on patch set 1 11/02/22, 17:58
PasswordHashFactoryTest.php:88ReplyThis depends on whether we define the check for availability to be part of the test statement. I don't really know the code - do you know more about whether the call to isAvailable is relevant? -
Nikita Hovratov commented on patch set 1 11/02/22, 18:36
PasswordHashFactoryTest.php:88ReplyThe exception raise already implicates that isAvailable was called. Otherwise the test would fail. So it is redundant. Whitebox testing should be avoided as much as possible anyway. -
Oliver Klee commented on patch set 1 11/03/22, 08:43
Talked with lolli about this, and we came to the conclusion that the call to isAvailable() actually is relevant to the test, and having a green test when the call is removed from the production code would be incorrect. New patchset coming up in a second. -
Oliver Klee commented on patch set 1 11/03/22, 08:44
PasswordHashFactoryTest.php:88ReplyDonePasswordHashFactoryTest.php:221ReplyDone -
Oliver Klee uploaded patch set 2 11/03/22, 08:44
-
Oliver Klee voted on patch set 2 CR +1 11/03/22, 08:44
-
core-ci voted on patch set 2 V +1 11/03/22, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33022
-
Oliver Klee voted on patch set 2 V +1 11/03/22, 08:53
-
Nikita Hovratov voted on patch set 2 V +1 CR +1 11/03/22, 09:06
-
Nikita Hovratov commented on patch set 2 11/03/22, 09:10
Reply
Ack -
Stefan Bürk voted on patch set 2 V +2 CR +2 11/03/22, 09:36
-
Stefan Bürk merged patch set 3 11/03/22, 09:36
PasswordHashFactoryTest.php:88