Review main Merged

76396[TASK] Update to PHPStan 1.9.0

Oliver Klee CR +2 V +2 Normal +28 −48 updated 11/03/22, 08:44

Commit message

This update finds new problems and gets rid of
some false positives.

Run commands:

> composer req --dev phpstan/phpstan:^1.9.0
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Blog article about the new release:
https://phpstan.org/blog/phpstan-1-9-0-with-phpdoc-asserts-list-type

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Oliver Klee uploaded patch set 1 11/03/22, 08:00

  2. core-ci voted on patch set 1 V +1 11/03/22, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33020

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 11/03/22, 08:10

  4. Benni Mack voted on patch set 1 V +1 CR +1 11/03/22, 08:17

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 11/03/22, 08:44

  6. Christian Kuhn merged patch set 2 11/03/22, 08:44