76398[BUGFIX] Use proper annotations to avoid type errors
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 15
- Build/phpstan/phpstan-baseline.neon+13 −68
- typo3/sysext/core/Tests/Unit/Localization/LocalesTest.php+1 −10
- typo3/sysext/core/Tests/Unit/Mail/MailMessageTest.php2+11 −54
- typo3/sysext/core/Tests/Unit/Resource/FileReferenceTest.php4+1 −28
- typo3/sysext/core/Tests/Unit/TypoScript/Parser/TypoScriptParserTest.php+0 −37
- typo3/sysext/frontend/Classes/ContentObject/Menu/MenuContentObjectFactory.php4+4 −11
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+1 −28
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/MenuContentObjectFactoryTest.php+0 −22
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+25 −56
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteBaseRedirectResolverTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest.php+1 −1
- typo3/sysext/install/Classes/Service/EnableFileService.php+1 −1
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+1 −1
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+1 −1
Review log 1824
-
Benni Mack uploaded patch set 1 11/03/22, 09:08
-
core-ci voted on patch set 1 V -1 11/03/22, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33027
-
Benni Mack uploaded patch set 2 11/03/22, 09:34
-
Stefan Bürk commented on patch set 2 11/03/22, 09:35
FileReferenceTest.php:30Not tested, but we should be able to make this a native return type and eliminate the docblock ``` : FileReference&MockObject&AccessibleObjectInterface ```MenuContentObjectFactory.php:44Not checked - but can we not add string type here too ?MenuContentObjectFactory.php:72Can we declare this class/factory now strict ? (missing above) -
core-ci voted on patch set 2 V -1 11/03/22, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33029
-
Benni Mack uploaded patch set 3 11/03/22, 10:08
-
Oliver Klee commented on patch set 3 11/03/22, 10:15
typo: calsses -> classes -
Oliver Klee commented on patch set 3 11/03/22, 10:17
FileReferenceTest.php:29These should be intersection types, not union types: FileReference&MockObject&AccessibleObjectInterface -
core-ci voted on patch set 3 V -1 11/03/22, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33031
-
Benni Mack commented on patch set 3 11/03/22, 10:38
FileReferenceTest.php:29Replyaah, you are rightFileReferenceTest.php:30ReplyDone -
Benni Mack commented on patch set 3 11/03/22, 10:38
MailMessageTest.php:104ReplyDoneMenuContentObjectFactory.php:44ReplyDoneMenuContentObjectFactory.php:72ReplyDone -
Benni Mack commented on patch set 4 11/03/22, 10:39
Published edit on patch set 3. -
Benni Mack updated the commit message in patch set 5 11/03/22, 10:39
-
Benni Mack commented on patch set 5 11/03/22, 10:39
Reply
Done -
core-ci voted on patch set 4 V -1 11/03/22, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33033
-
core-ci voted on patch set 5 V -1 11/03/22, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33034
-
Oliver Klee commented on patch set 5 11/03/22, 10:52
typing -> type (as it's not about typos, but data types) -
Benni Mack uploaded patch set 6 11/03/22, 11:13
-
Benni Mack commented on patch set 6 11/03/22, 11:13
Reply
Done -
core-ci voted on patch set 6 V +1 11/03/22, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33035
-
Oliver Klee voted on patch set 6 V +1 CR +1 11/03/22, 11:29
-
Christian Kuhn voted on patch set 6 V +1 CR +1 11/03/22, 11:30
-
Benni Mack commented on patch set 6 V +2 CR +2 11/03/22, 12:00
I'll merge this, hope that's OK with you, Stefan -
Benni Mack merged patch set 7 11/03/22, 12:01
MailMessageTest.php:104