Review main Merged

76398[BUGFIX] Use proper annotations to avoid type errors

Benni Mack CR +2 V +2 Hard +63 −321 updated 11/03/22, 12:01

Commit message

This is mainly related to test files,
where the phpdoc annotations of the affected
test classes have been removed, as we now use
proper native types, where no additional
PHPDoc comment describing the parameters
are  set.

In addition, some further cleanups related
to types that have already been properly
defined are set.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1824

  1. Benni Mack uploaded patch set 1 11/03/22, 09:08

  2. core-ci voted on patch set 1 V -1 11/03/22, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33027

  3. Benni Mack uploaded patch set 2 11/03/22, 09:34

  4. Stefan Bürk commented on patch set 2 11/03/22, 09:35

    MailMessageTest.php:104

    must be nullable name, because of L88 (null) value

    FileReferenceTest.php:30

    Not tested, but we should be able to make this a native return type and eliminate the docblock ``` : FileReference&MockObject&AccessibleObjectInterface ```

    MenuContentObjectFactory.php:44

    Not checked - but can we not add string type here too ?

    MenuContentObjectFactory.php:72

    Can we declare this class/factory now strict ? (missing above)
  5. core-ci voted on patch set 2 V -1 11/03/22, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33029

  6. Benni Mack uploaded patch set 3 11/03/22, 10:08

  7. Oliver Klee commented on patch set 3 11/03/22, 10:15

    typo: calsses -> classes
  8. Oliver Klee commented on patch set 3 11/03/22, 10:17

    FileReferenceTest.php:29

    These should be intersection types, not union types: FileReference&MockObject&AccessibleObjectInterface
  9. core-ci voted on patch set 3 V -1 11/03/22, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33031

  10. Benni Mack commented on patch set 3 11/03/22, 10:38

    FileReferenceTest.php:29 Reply

    aah, you are right

    FileReferenceTest.php:30 Reply

    Done
  11. Benni Mack commented on patch set 3 11/03/22, 10:38

    MailMessageTest.php:104 Reply

    Done

    MenuContentObjectFactory.php:44 Reply

    Done

    MenuContentObjectFactory.php:72 Reply

    Done
  12. Benni Mack commented on patch set 4 11/03/22, 10:39

    Published edit on patch set 3.
  13. Benni Mack updated the commit message in patch set 5 11/03/22, 10:39

  14. Benni Mack commented on patch set 5 11/03/22, 10:39

    Reply

    Done
  15. core-ci voted on patch set 4 V -1 11/03/22, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33033

  16. core-ci voted on patch set 5 V -1 11/03/22, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33034

  17. Oliver Klee commented on patch set 5 11/03/22, 10:52

    typing -> type (as it's not about typos, but data types)
  18. Benni Mack uploaded patch set 6 11/03/22, 11:13

  19. Benni Mack commented on patch set 6 11/03/22, 11:13

    Reply

    Done
  20. core-ci voted on patch set 6 V +1 11/03/22, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33035

  21. Oliver Klee voted on patch set 6 V +1 CR +1 11/03/22, 11:29

  22. Christian Kuhn voted on patch set 6 V +1 CR +1 11/03/22, 11:30

  23. Benni Mack commented on patch set 6 V +2 CR +2 11/03/22, 12:00

    I'll merge this, hope that's OK with you, Stefan
  24. Benni Mack merged patch set 7 11/03/22, 12:01