Review 11.5 Merged

76404[BUGFIX] Have CKEditor link plugin keep tags

Benni Mack CR +2 V +2 Easy +5 −2 updated 11/14/22, 09:13

Commit message

When using TYPO3's custom link plugin
for CKEditor, special tags / attributes
within the link (e.g. <em>) are now kept.

Previously, all custom tags were removed, as only
text was taken, but if the link was added without
the link plugin, the problem did not exist.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 11/03/22, 16:07

  2. Benni Mack updated the commit message in patch set 2 11/03/22, 16:15

  3. core-ci voted on patch set 1 V +1 11/03/22, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33056

  4. core-ci voted on patch set 2 V +1 11/03/22, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33057

  5. Oliver Hader commented on patch set 2 V +1 CR +1 11/04/22, 11:56

    Having e.g. `<strong><em>sophisticated</em></strong>` is now wrapped correctly as `<a href="t3://page?uid=80#6"><strong><em>sophisticated</em></strong></a>`. Thx!
  6. Oli Bartsch voted on patch set 2 V +1 CR +1 11/04/22, 13:26

  7. Benni Mack voted on patch set 2 V +2 CR +2 11/04/22, 13:51

  8. Benni Mack merged patch set 3 11/04/22, 13:51

  9. Benni Mack wrote 11/14/22, 09:13

    Created a revert of this change as I7aee1dec8f4197305156f204db27c6f0704762c2