Review main Merged

76405[TASK] Allow multiple actions and custom invoke handlers for search results

Andreas Kienast CR +2 V +2 Expert +878 −269 updated 11/28/22, 14:06

Commit message

Search results now may have multiple actions to trigger, depending on
their context. For pages it'd make sense to either open them in the
backend or the frontend. Those actions are rendered next to the focussed
search result.

Invoke handlers may now get registered for custom search result items
that allow to modify the behavior when selecting a result item, e.g.
calculating and opening a different URL based on data that is not
available via PHP.

As a base example, the `PageRecordProvider` brings a custom invoke
handler for an action to open a page in a new browser tab.

This feature is purposely not documented as such as behavior or API may
change in further iterations.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 33

Show 13 more files

Review log 2947

Show 1422 earlier messages
  1. Andreas Kienast uploaded patch set 1 11/03/22, 16:45

  2. core-ci voted on patch set 1 V -1 11/03/22, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33061

  3. Andreas Kienast uploaded patch set 2 11/07/22, 14:20

  4. core-ci voted on patch set 2 V +1 11/07/22, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33209

  5. Georg Ringer commented on patch set 2 11/09/22, 09:05

    locallang.xlf:379

    we got this translation already in EXT:workspaces/Resources/Private/Language/locallang_mod_user_ws.xlf
  6. Andreas Kienast uploaded patch set 3 11/15/22, 10:16

  7. Andreas Kienast commented on patch set 3 11/15/22, 10:17

    locallang.xlf:379 Reply

    Done
  8. core-ci voted on patch set 3 V -1 11/15/22, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33743

  9. Andreas Kienast uploaded patch set 4 11/15/22, 11:44

  10. core-ci voted on patch set 4 V +1 11/15/22, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33747

  11. Benni Mack commented on patch set 4 CR -1 11/15/22, 15:38

    cool thing

    AfterBackendPageRenderEventListener.php:27

    please rename the event listener to "AddWorkspaceSearchProviderEventListener"
  12. Andreas Kienast uploaded patch set 5 11/15/22, 15:53

  13. Andreas Kienast commented on patch set 5 11/15/22, 16:00

    AfterBackendPageRenderEventListener.php:27 Reply

    Done
  14. core-ci voted on patch set 5 V +1 11/15/22, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33770

  15. Andreas Kienast commented on patch set 5 CR -2 11/16/22, 14:50

    Will rework the concept, Frank wants to have the possibility of multiple actions per record type.
  16. Andreas Kienast uploaded patch set 6 11/18/22, 10:34

  17. core-ci voted on patch set 6 V +1 11/18/22, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33910

  18. Andreas Kienast uploaded patch set 7 11/18/22, 14:55

  19. core-ci voted on patch set 7 V -1 11/18/22, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33920

  20. Andreas Kienast uploaded patch set 8 V -1 11/21/22, 12:12

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  21. core-ci voted on patch set 8 V -1 11/21/22, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34037

  22. Andreas Kienast uploaded patch set 9 V -1 11/21/22, 15:12

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  1. Andreas Kienast voted on patch set 9 CR 0 11/21/22, 15:13

  2. core-ci voted on patch set 9 V -1 11/21/22, 15:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34046

  3. Andreas Kienast uploaded patch set 10 V -1 11/22/22, 09:31

  4. core-ci voted on patch set 10 V +1 11/22/22, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34062

  5. Frank Nägler voted on patch set 10 V +1 CR +1 11/22/22, 13:37

  6. Andreas Kienast uploaded patch set 11 CR +1 V +1 11/23/22, 08:28

  7. core-ci voted on patch set 11 V +1 11/23/22, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34100

  8. Frank Nägler voted on patch set 11 V +1 CR +1 11/23/22, 08:43

  9. Andreas Kienast uploaded patch set 12 CR +1 V +1 11/23/22, 09:56

  10. core-ci voted on patch set 12 V +1 11/23/22, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34107

  11. Andreas Kienast uploaded patch set 13 V +1 11/24/22, 07:16

  12. core-ci voted on patch set 13 V +1 11/24/22, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34155

  13. Andreas Kienast uploaded patch set 14 V +1 11/25/22, 12:44

  14. core-ci voted on patch set 14 V -1 11/25/22, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34214

  15. Andreas Kienast rebased onto patch set 15 V -1 11/25/22, 14:07

  16. core-ci voted on patch set 15 V +1 11/25/22, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34225

  17. Andreas Kienast uploaded patch set 16 V +1 11/25/22, 14:27

  18. core-ci voted on patch set 16 V -1 11/25/22, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34232

  19. Andreas Kienast rebased onto patch set 17 V -1 11/25/22, 16:24

  20. core-ci voted on patch set 17 V +1 11/25/22, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34237

  21. Andreas Kienast uploaded patch set 18 V +1 11/28/22, 12:05

  22. core-ci voted on patch set 18 V +1 11/28/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34316

  23. Susi Moog voted on patch set 18 V +1 CR +1 11/28/22, 12:42

  24. Benni Mack voted on patch set 18 V +2 CR +2 11/28/22, 14:06

  25. Andreas Kienast merged patch set 19 11/28/22, 14:06