Review main Merged

76408[TASK] Disable xdebug for phpstan command execution

Stefan Bürk CR +2 V +2 Easy +2 −0 updated 11/04/22, 10:32

Commit message

PHPStan recently added a xdebug check The TYPO3 core
php testing images has xdebug installed and enabled
in cli mode, which now let PHPStan display a speaking
notice about this circumstance.

This change simply disable xdebug for phpstan calls
in runTests.sh, thus avoiding this notice. xdebug is
not needed to be enabled for PHPStan executions.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Stefan Bürk uploaded patch set 1 11/03/22, 18:00

  2. Stefan Bürk updated the commit message in patch set 2 11/03/22, 18:06

  3. core-ci voted on patch set 1 V -1 11/03/22, 18:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33066

  4. core-ci voted on patch set 2 V -1 11/03/22, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33067

  5. Stefan Bürk updated the commit message in patch set 3 11/03/22, 18:23

  6. core-ci voted on patch set 3 V -1 11/03/22, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33068

  7. Stefan Bürk rebased onto patch set 4 11/03/22, 18:40

  8. core-ci voted on patch set 4 V +1 11/03/22, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33072

  9. Georg Ringer voted on patch set 4 V +1 CR +1 11/03/22, 20:49

  10. Benni Mack voted on patch set 4 V +1 CR +1 11/04/22, 10:06

  11. Stefan Bürk voted on patch set 4 V +2 CR +2 11/04/22, 10:32

  12. Stefan Bürk merged patch set 5 11/04/22, 10:32