76411[FEATURE] Add more location possibilities to ENABLE_INSTALL_TOOL
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-98528-NewFileLocationForENABLE_INSTALL_TOOL.rstnew+34 −0
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/AbstractCest.php+8 −3
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/LoginCest.php+4 −5
- typo3/sysext/install/Classes/Controller/LoginController.php+3 −0
- typo3/sysext/install/Classes/Report/SecurityStatusReport.php+1 −2
- typo3/sysext/install/Classes/Service/EnableFileService.php+35 −37
- typo3/sysext/install/Resources/Private/Language/BackendModule.xlf+1 −8
- typo3/sysext/install/Resources/Private/Templates/Login/ShowEnableInstallToolFile.html+1 −1
Review log 1826
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 11/03/22, 20:31
-
Benni Mack commented on patch set 2 11/03/22, 20:44
Published edit on patch set 1. -
core-ci voted on patch set 1 V -1 11/03/22, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33081
-
core-ci voted on patch set 2 V -1 11/03/22, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33084
-
Benni Mack uploaded patch set 3 11/04/22, 10:01
-
core-ci voted on patch set 3 V +1 11/04/22, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33097
-
Georg Ringer commented on patch set 3 CR -1 11/09/22, 21:49
while I find it nice to move things out of typo3conf I don't like to have various paths available. reviewing projects in 2 years will give you headaches because e.g. on all possible places such files will be available. I would be in favor just as with localconfiguration, additionalconfiguration,.. that there is just one place. as 12.0 is released we can just deprecate that old place, e.g. when composer is used but that is fine as well -
Georg Ringer uploaded patch set 4
CR -1V +101/19/23, 07:23 -
core-ci voted on patch set 4 V +1 01/19/23, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36168
-
Josef Glatz commented on patch set 4 01/19/23, 08:16
RsT to make people aware this topic is needed in my pov -
Georg Ringer uploaded patch set 5
V +101/19/23, 11:07 -
core-ci voted on patch set 5 V +1 01/19/23, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36197
-
Josef Glatz updated the commit message in patch set 6
V +101/19/23, 11:44 -
Josef Glatz commented on patch set 6 CR -1 01/19/23, 11:45
what does "best" location mean in this context? -
core-ci voted on patch set 6 V +1 01/19/23, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36215
-
Georg Ringer updated the commit message in patch set 7
CR -1V +101/19/23, 13:09 -
core-ci voted on patch set 7 V +1 01/19/23, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36244
-
Josef Glatz voted on patch set 7 CR +1 01/19/23, 13:48
-
Josef Glatz updated the commit message in patch set 8
CR +1V +101/19/23, 14:06 -
Josef Glatz commented on patch set 8 CR +1 01/19/23, 14:08
How can I test the composer mode on a cherry pick? I've tested the patch except for the mentioned composer mode. Patching the latest available composer packages for v12? -
core-ci voted on patch set 8 V +1 01/19/23, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36251
-
Josef Glatz commented on patch set 8 V +1 01/19/23, 15:04
Reply
Done -
Benni Mack commented on patch set 8 01/19/23, 16:12
Reply
Done -
Georg Ringer voted on patch set 8 V +1 CR +1 01/19/23, 16:24
-
Benni Mack voted on patch set 8 V +2 CR +2 01/19/23, 16:50
-
Benni Mack merged patch set 9 01/19/23, 16:50