Review main Merged

76411[FEATURE] Add more location possibilities to ENABLE_INSTALL_TOOL

Benni Mack CR +2 V +2 Normal +87 −56 updated 01/19/23, 16:50

Commit message

To phase out the usage of the directory `typo3conf`, the file
`ENABLE_INSTALL_TOOL` can be created at alternative directories:

For composer-based installations the following file paths are checked:
- `var/transient/ENABLE_INSTALL_TOOL`
- `config/ENABLE_INSTALL_TOOL`

For non-composer-based installations the following file paths are checked:
- `typo3temp/var/transient/ENABLE_INSTALL_TOOL`
- `typo3conf/ENABLE_INSTALL_TOOL`

The previous path `typo3conf/ENABLE_INSTALL_TOOL` is still supported as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1826

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 11/03/22, 20:31

  1. Benni Mack commented on patch set 2 11/03/22, 20:44

    Published edit on patch set 1.
  2. core-ci voted on patch set 1 V -1 11/03/22, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33081

  3. core-ci voted on patch set 2 V -1 11/03/22, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33084

  4. Benni Mack uploaded patch set 3 11/04/22, 10:01

  5. core-ci voted on patch set 3 V +1 11/04/22, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33097

  6. Georg Ringer commented on patch set 3 CR -1 11/09/22, 21:49

    while I find it nice to move things out of typo3conf I don't like to have various paths available. reviewing projects in 2 years will give you headaches because e.g. on all possible places such files will be available. I would be in favor just as with localconfiguration, additionalconfiguration,.. that there is just one place. as 12.0 is released we can just deprecate that old place, e.g. when composer is used but that is fine as well
  7. Georg Ringer uploaded patch set 4 CR -1 V +1 01/19/23, 07:23

  8. core-ci voted on patch set 4 V +1 01/19/23, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36168

  9. Josef Glatz commented on patch set 4 01/19/23, 08:16

    RsT to make people aware this topic is needed in my pov
  10. Georg Ringer uploaded patch set 5 V +1 01/19/23, 11:07

  11. core-ci voted on patch set 5 V +1 01/19/23, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36197

  12. Josef Glatz updated the commit message in patch set 6 V +1 01/19/23, 11:44

  13. Josef Glatz commented on patch set 6 CR -1 01/19/23, 11:45

    what does "best" location mean in this context?
  14. core-ci voted on patch set 6 V +1 01/19/23, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36215

  15. Georg Ringer updated the commit message in patch set 7 CR -1 V +1 01/19/23, 13:09

  16. core-ci voted on patch set 7 V +1 01/19/23, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36244

  17. Josef Glatz voted on patch set 7 CR +1 01/19/23, 13:48

  18. Josef Glatz updated the commit message in patch set 8 CR +1 V +1 01/19/23, 14:06

  19. Josef Glatz commented on patch set 8 CR +1 01/19/23, 14:08

    How can I test the composer mode on a cherry pick? I've tested the patch except for the mentioned composer mode. Patching the latest available composer packages for v12?
  20. core-ci voted on patch set 8 V +1 01/19/23, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36251

  21. Josef Glatz commented on patch set 8 V +1 01/19/23, 15:04

    Reply

    Done
  22. Benni Mack commented on patch set 8 01/19/23, 16:12

    Reply

    Done
  23. Georg Ringer voted on patch set 8 V +1 CR +1 01/19/23, 16:24

  24. Benni Mack voted on patch set 8 V +2 CR +2 01/19/23, 16:50

  25. Benni Mack merged patch set 9 01/19/23, 16:50