Review main Merged

76432[TASK] Replace prophecy in EXT:core AbstractConditionMatcherTest

Nikita Hovratov CR +2 V +2 Normal +16 −141 updated 11/03/22, 21:28

Commit message

Also, remove obsolete Fixture functions.

Used command(s):

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Kevin Appelt +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Kevin Appelt +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 68

  1. Nikita Hovratov uploaded patch set 1 11/03/22, 20:31

  2. core-ci voted on patch set 1 V -1 11/03/22, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33082

  3. Stefan Bürk commented on patch set 1 CR -1 11/03/22, 21:01

    on it
  4. Stefan Bürk uploaded patch set 2 11/03/22, 21:07

  5. core-ci voted on patch set 2 V +1 11/03/22, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33085

  6. Kevin Appelt voted on patch set 2 V +1 CR +1 11/03/22, 21:18

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 11/03/22, 21:28

  8. Stefan Bürk merged patch set 3 11/03/22, 21:28