Review main Merged

76436[TASK] Replace prophecy in EXT:backend/*/Unit/Form/NodeFactoryTest.php

Torben Hansen CR +2 V +2 Easy +9 −15 updated 11/04/22, 14:47

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1317

  1. Torben Hansen uploaded patch set 1 11/04/22, 12:49

  2. core-ci voted on patch set 1 V +1 11/04/22, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33116

  3. Oliver Klee voted on patch set 1 V +1 11/04/22, 13:36

  4. Oliver Klee voted on patch set 1 CR +1 11/04/22, 13:38

  5. Stefan Bürk updated the commit message in patch set 2 11/04/22, 13:43

  6. Stefan Bürk commented on patch set 2 11/04/22, 13:45

    NodeFactoryTest.php:294

    The "Revelation" step can be omited for mocks. Does not make much sense. Just use $unknownElementMock directly.

    NodeFactoryTest.php:310

    same as above ...

    NodeFactoryTest.php:332

    same as above ...
  7. Torben Hansen uploaded patch set 3 11/04/22, 13:50

  8. Torben Hansen commented on patch set 3 11/04/22, 13:51

    NodeFactoryTest.php:294 Reply

    Done

    NodeFactoryTest.php:310 Reply

    Done

    NodeFactoryTest.php:332 Reply

    Done
  9. Stefan Bürk updated the commit message in patch set 4 11/04/22, 13:53

  10. Stefan Bürk voted on patch set 4 V +1 CR +1 11/04/22, 13:53

  11. core-ci voted on patch set 2 V +1 11/04/22, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33122

  12. core-ci voted on patch set 3 V +1 11/04/22, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33124

  13. core-ci voted on patch set 4 V +1 11/04/22, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33125

  14. Oliver Klee voted on patch set 4 V +1 11/04/22, 14:37

  15. Oliver Klee voted on patch set 4 CR +1 11/04/22, 14:37

  16. Stefan Bürk voted on patch set 4 V +2 CR +2 11/04/22, 14:47

  17. Stefan Bürk merged patch set 5 11/04/22, 14:47