Review main Merged

76437[TASK] Replace prophecy in EXT:backend/*/Unit/*/FormDataCompilerTest.php

Torben Hansen CR +2 V +2 Easy +13 −19 updated 11/07/22, 14:40

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1317

  1. Torben Hansen uploaded patch set 1 11/04/22, 13:22

  2. core-ci voted on patch set 1 V +1 11/04/22, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33120

  3. Oliver Klee voted on patch set 1 V +1 11/04/22, 13:36

  4. Oliver Klee commented on patch set 1 11/04/22, 13:37

    FormDataCompilerTest.php:126

    Why this change from $arguments[0] to $arguments?
  5. Stefan Bürk updated the commit message in patch set 2 11/04/22, 13:46

  6. Torben Hansen commented on patch set 2 11/04/22, 13:47

    FormDataCompilerTest.php:126 Reply

    The test failed with "Undefined array key 0". Since $argument is always an array (either empty or with strings as keys), I was really wondering, how this could have worked previously with PHP8+.
  7. Stefan Bürk commented on patch set 2 11/04/22, 13:51

    FormDataCompilerTest.php:126 Reply

    The array key access arror is obvious - why this has not failed prio is a really good guestion ....
  8. Stefan Bürk updated the commit message in patch set 3 11/04/22, 13:54

  9. Stefan Bürk updated the commit message in patch set 4 11/04/22, 13:54

  10. core-ci voted on patch set 2 V +1 11/04/22, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33123

  11. core-ci voted on patch set 4 V +1 11/04/22, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33127

  12. core-ci voted on patch set 3 V +1 11/04/22, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33126

  13. Oliver Klee commented on patch set 4 11/04/22, 14:36

    FormDataCompilerTest.php:126 Reply

    Ack
  14. Oliver Klee voted on patch set 4 V +1 11/04/22, 14:37

  15. Christian Kuhn voted on patch set 4 V +1 CR +1 11/07/22, 14:37

  16. Stefan Bürk voted on patch set 4 V +2 CR +2 11/07/22, 14:40

  17. Stefan Bürk merged patch set 5 11/07/22, 14:40