Review main Merged

76441[FEATURE] Create new folder in modal dialog

Benni Mack CR +2 V +2 Hard +328 −287 updated 12/13/22, 11:57

Commit message

This change moves the "Create folder" route to the modal, so that
editors do not lose the focus when working with the file list.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 3553

Show 1828 earlier messages
  1. Benni Mack uploaded patch set 1 11/04/22, 14:50

  2. core-ci voted on patch set 1 V -1 11/04/22, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33133

  3. Andreas Kienast commented on patch set 1 11/07/22, 07:29

    FileListController.php:536

    I think this won't work in any way. IIRC, providing data attributes only builds a modal that intercepts the request only, denying any possibility to add some custom logic.
  4. Andreas Kienast uploaded patch set 2 V -1 11/23/22, 15:41

  5. core-ci voted on patch set 2 V -1 11/23/22, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34120

  6. Andreas Kienast uploaded patch set 3 V -1 11/23/22, 15:53

  7. Andreas Kienast commented on patch set 3 11/23/22, 15:57

    FileListController.php:536 Reply

    Done
  8. core-ci voted on patch set 3 V -1 11/23/22, 16:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34121

  9. Benni Mack commented on patch set 3 11/23/22, 16:36

    CreateFolderController.php:147

    I think we can delete create-folder.js/ts now
  10. Andreas Kienast commented on patch set 3 11/25/22, 08:13

    CreateFolderController.php:147 Reply

    Ack
  11. Andreas Kienast uploaded patch set 4 V -1 11/25/22, 08:28

  12. Oliver Klee commented on patch set 4 11/25/22, 08:34

    typo: loose -> lose
  13. core-ci voted on patch set 4 V -1 11/25/22, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34198

  14. Andreas Kienast uploaded patch set 5 V -1 11/25/22, 10:58

  15. Andreas Kienast commented on patch set 5 11/25/22, 10:59

    Reply

    Done
  16. core-ci voted on patch set 5 V -1 11/25/22, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34204

  17. Andreas Kienast uploaded patch set 6 V -1 11/25/22, 11:36

  18. core-ci voted on patch set 6 V -1 11/25/22, 11:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34205

  19. Andreas Kienast uploaded patch set 7 V -1 11/25/22, 11:51

  20. Oliver Klee wrote 11/25/22, 11:52

    Removed cc Oliver Klee.
  21. Andreas Kienast commented on patch set 7 V -1 11/25/22, 11:53

    context menu is broken when not on the "index" view.
  22. Benni Mack uploaded patch set 8 V -1 11/25/22, 12:05

  23. core-ci voted on patch set 7 V -1 11/25/22, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34206

  24. core-ci voted on patch set 8 V -1 11/25/22, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34209

  25. Andreas Kienast uploaded patch set 9 V -1 12/01/22, 15:01

  26. core-ci voted on patch set 9 V -1 12/01/22, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34503

  27. Andreas Kienast uploaded patch set 10 V -1 12/01/22, 17:40

  28. core-ci voted on patch set 10 V +1 12/01/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34521

  1. Benni Mack commented on patch set 10 12/01/22, 21:22

    Just tested it now, and I really like it. One thing (the ONLY thing) that I struggle with UX wise is that - after I created the new folder - there is no button that says "jump to this folder" (or whatever) that closes the modal and jumps to the new folder in the file list-
  2. Chris Müller uploaded patch set 11 V +1 12/04/22, 18:14

  3. core-ci voted on patch set 11 V +1 12/04/22, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34610

  4. Andreas Kienast commented on patch set 11 12/04/22, 18:28

    Hey Chris. I‘m sorry, I have pending changes on that patch I didn‘t push yet. I‘ll check your changes ASAP.
  5. Andreas Kienast uploaded patch set 12 V +1 12/05/22, 05:57

  6. core-ci voted on patch set 12 V +1 12/05/22, 06:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34623

  7. Georg Ringer commented on patch set 12 12/05/22, 09:08

    the "open-module" action in the modal to switch to a directory must also close the modal and not only move to the directory in the window behind
  8. Georg Ringer voted on patch set 12 CR -1 12/05/22, 09:08

  9. Andreas Kienast commented on patch set 12 12/05/22, 09:43

    Reply

    Good point
  10. Andreas Kienast uploaded patch set 13 CR -1 V +1 12/05/22, 09:43

  11. core-ci voted on patch set 13 V +1 12/05/22, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34625

  12. Benni Mack commented on patch set 14 V +1 12/06/22, 10:48

    Published edit on patch set 13.
  13. core-ci voted on patch set 14 V +1 12/06/22, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34706

  14. Georg Ringer uploaded patch set 15 V +1 12/12/22, 14:13

  15. core-ci voted on patch set 15 V +1 12/12/22, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34916

  16. Andreas Kienast commented on patch set 15 CR -1 12/12/22, 14:28

    looks like an accidental re-push
  17. Andreas Kienast uploaded patch set 16 CR -1 V +1 12/12/22, 14:29

  18. core-ci voted on patch set 16 V +1 12/12/22, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34919

  19. Oli Bartsch uploaded patch set 17 V +1 12/13/22, 11:22

  20. Oli Bartsch rebased onto patch set 18 12/13/22, 11:22

  21. core-ci voted on patch set 18 V +1 12/13/22, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35034

  22. core-ci voted on patch set 17 V +1 12/13/22, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35033

  23. Andreas Kienast voted on patch set 18 V +1 CR +1 12/13/22, 11:57

  24. Oli Bartsch voted on patch set 18 V +2 CR +2 12/13/22, 11:57

  25. Oli Bartsch merged patch set 19 12/13/22, 11:57