76441[FEATURE] Create new folder in modal dialog
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 18
- Build/Sources/TypeScript/filelist/context-menu-actions.ts+11 −0
- Build/Sources/TypeScript/filelist/create-folder.ts+28 −46
- Build/Sources/TypeScript/filelist/file-list.ts+37 −3
- typo3/sysext/backend/Classes/ElementBrowser/AbstractElementBrowser.php+3 −3
- typo3/sysext/backend/Classes/ElementBrowser/CreateFolderBrowser.phpnew+113 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_browse_links.xlf+3 −0
- typo3/sysext/backend/Resources/Private/Templates/ElementBrowser/CreateFolder.htmlnew+67 −0
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-99191-CreateFoldersViaModals.rstnew+31 −0
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileStorageTreeFilterCest.php+11 −6
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+9 −2
- typo3/sysext/filelist/Classes/Controller/File/CreateFolderController.php2deleted+0 −154
- typo3/sysext/filelist/Classes/Controller/FileListController.php2+12 −8
- typo3/sysext/filelist/Configuration/Backend/Routes.php+0 −6
- typo3/sysext/filelist/Resources/Private/Language/locallang.xlf+0 −3
- typo3/sysext/filelist/Resources/Private/Templates/File/CreateFolder.htmldeleted+0 −53
- typo3/sysext/filelist/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/create-folder.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list.js+1 −1
Review log 3553
Show 1828 earlier messages
-
Benni Mack uploaded patch set 1 11/04/22, 14:50
-
core-ci voted on patch set 1 V -1 11/04/22, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33133
-
Andreas Kienast commented on patch set 1 11/07/22, 07:29
-
Andreas Kienast uploaded patch set 2
V -111/23/22, 15:41 -
core-ci voted on patch set 2 V -1 11/23/22, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34120
-
Andreas Kienast uploaded patch set 3
V -111/23/22, 15:53 -
Andreas Kienast commented on patch set 3 11/23/22, 15:57
FileListController.php:536ReplyDone -
core-ci voted on patch set 3 V -1 11/23/22, 16:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34121
-
Benni Mack commented on patch set 3 11/23/22, 16:36
CreateFolderController.php:147I think we can delete create-folder.js/ts now -
Andreas Kienast commented on patch set 3 11/25/22, 08:13
CreateFolderController.php:147ReplyAck -
Andreas Kienast uploaded patch set 4
V -111/25/22, 08:28 -
Oliver Klee commented on patch set 4 11/25/22, 08:34
typo: loose -> lose -
core-ci voted on patch set 4 V -1 11/25/22, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34198
-
Andreas Kienast uploaded patch set 5
V -111/25/22, 10:58 -
Andreas Kienast commented on patch set 5 11/25/22, 10:59
Reply
Done -
core-ci voted on patch set 5 V -1 11/25/22, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34204
-
Andreas Kienast uploaded patch set 6
V -111/25/22, 11:36 -
core-ci voted on patch set 6 V -1 11/25/22, 11:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34205
-
Andreas Kienast uploaded patch set 7
V -111/25/22, 11:51 -
Oliver Klee wrote 11/25/22, 11:52
Removed cc Oliver Klee. -
Andreas Kienast commented on patch set 7 V -1 11/25/22, 11:53
context menu is broken when not on the "index" view. -
Benni Mack uploaded patch set 8
V -111/25/22, 12:05 -
core-ci voted on patch set 7 V -1 11/25/22, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34206
-
core-ci voted on patch set 8 V -1 11/25/22, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34209
-
Andreas Kienast uploaded patch set 9
V -112/01/22, 15:01 -
core-ci voted on patch set 9 V -1 12/01/22, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34503
-
Andreas Kienast uploaded patch set 10
V -112/01/22, 17:40 -
core-ci voted on patch set 10 V +1 12/01/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34521
-
Benni Mack commented on patch set 10 12/01/22, 21:22
Just tested it now, and I really like it. One thing (the ONLY thing) that I struggle with UX wise is that - after I created the new folder - there is no button that says "jump to this folder" (or whatever) that closes the modal and jumps to the new folder in the file list- -
Chris Müller uploaded patch set 11
V +112/04/22, 18:14 -
core-ci voted on patch set 11 V +1 12/04/22, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34610
-
Andreas Kienast commented on patch set 11 12/04/22, 18:28
Hey Chris. I‘m sorry, I have pending changes on that patch I didn‘t push yet. I‘ll check your changes ASAP. -
Andreas Kienast uploaded patch set 12
V +112/05/22, 05:57 -
core-ci voted on patch set 12 V +1 12/05/22, 06:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34623
-
Georg Ringer commented on patch set 12 12/05/22, 09:08
the "open-module" action in the modal to switch to a directory must also close the modal and not only move to the directory in the window behind -
Georg Ringer voted on patch set 12 CR -1 12/05/22, 09:08
-
Andreas Kienast commented on patch set 12 12/05/22, 09:43
Reply
Good point -
Andreas Kienast uploaded patch set 13
CR -1V +112/05/22, 09:43 -
core-ci voted on patch set 13 V +1 12/05/22, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34625
-
Benni Mack commented on patch set 14
V +112/06/22, 10:48Published edit on patch set 13. -
core-ci voted on patch set 14 V +1 12/06/22, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34706
-
Georg Ringer uploaded patch set 15
V +112/12/22, 14:13 -
core-ci voted on patch set 15 V +1 12/12/22, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34916
-
Andreas Kienast commented on patch set 15 CR -1 12/12/22, 14:28
looks like an accidental re-push -
Andreas Kienast uploaded patch set 16
CR -1V +112/12/22, 14:29 -
core-ci voted on patch set 16 V +1 12/12/22, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34919
-
Oli Bartsch uploaded patch set 17
V +112/13/22, 11:22 -
Oli Bartsch rebased onto patch set 18 12/13/22, 11:22
-
core-ci voted on patch set 18 V +1 12/13/22, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35034
-
core-ci voted on patch set 17 V +1 12/13/22, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35033
-
Andreas Kienast voted on patch set 18 V +1 CR +1 12/13/22, 11:57
-
Oli Bartsch voted on patch set 18 V +2 CR +2 12/13/22, 11:57
-
Oli Bartsch merged patch set 19 12/13/22, 11:57
FileListController.php:536