76443[BUGFIX] Speed up FormEngine with hundreds of categories
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- Susi Moog +1
- core-ci +1 CI
Issues 5
- Bug #84558TYPO3 sys_category problem with performance/slow opening category in BE
- Feature #90398Add cache for category fields in TCA
- Bug #97003Get "Navigation loading error. Got unexpected response from the server. Please check logs for details." when fetch request is canceled.
- Bug #76581Backend Performance Flaws
- Task #98807Replace prophecy in EXT:core/Tests/Unit/Tree/TableConfiguration/DatabaseTreeDataProviderTest.php
Files 6
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php1+24 −12
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaCategory.php+17 −2
- typo3/sysext/backend/Classes/Tree/TreeNode.php+16 −1
- typo3/sysext/core/Classes/Tree/TableConfiguration/AbstractTableConfigurationTreeDataProvider.php+15 −0
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+30 −17
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/DatabaseTreeDataProviderTest.php+14 −162
Review log 1724
-
Benni Mack uploaded patch set 1 11/05/22, 14:19
-
core-ci voted on patch set 1 V -1 11/05/22, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33145
-
Benni Mack updated the commit message in patch set 2 11/05/22, 14:36
-
core-ci voted on patch set 2 V -1 11/05/22, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33146
-
Benni Mack uploaded patch set 3 11/05/22, 21:08
-
core-ci voted on patch set 3 V -1 11/05/22, 21:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33153
-
Benni Mack uploaded patch set 4 11/06/22, 13:25
-
core-ci voted on patch set 4 V -1 11/06/22, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33167
-
Benni Mack uploaded patch set 5 11/06/22, 21:38
-
core-ci voted on patch set 5 V -1 11/06/22, 21:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33172
-
Christian Kuhn commented on patch set 5 CR -1 11/07/22, 19:15
working on it, will push. -
Christian Kuhn uploaded patch set 6 11/08/22, 09:34
-
Christian Kuhn commented on patch set 6 11/08/22, 09:34
AbstractItemProvider.php:544let's make this argument a bool to not move sql parts around. -
core-ci voted on patch set 6 V -1 11/08/22, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33282
-
Christian Kuhn uploaded patch set 7 11/08/22, 09:49
-
core-ci voted on patch set 7 V +1 11/08/22, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33284
-
Christian Kuhn commented on patch set 7 11/08/22, 09:58
this is of course a hack and we know it. it's fine from my side, to enable a v11 backport for this. mid-term we should however see if we could get rid of the entire TreeDataProvider stuff in v12, though. -
Christian Kuhn voted on patch set 7 V +1 CR +1 11/08/22, 10:00
-
Oli Bartsch commented on patch set 7 CR -1 11/08/22, 10:03
Reviewing .. -
Susi Moog voted on patch set 7 CR +1 11/08/22, 10:22
-
Oli Bartsch voted on patch set 7 V +1 CR +1 11/08/22, 10:34
-
Susi Moog voted on patch set 7 V +1 11/08/22, 10:35
-
Benni Mack voted on patch set 7 V +2 CR +2 11/08/22, 10:40
-
Benni Mack merged patch set 8 11/08/22, 10:40