76444[BUGFIX] Clean up TCA Tree code base
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 5
- Build/phpstan/phpstan-baseline.neon+0 −15
- typo3/sysext/backend/Classes/Tree/AbstractTreeDataProvider.php+2 −2
- typo3/sysext/backend/Classes/Tree/TreeNode.php2+14 −14
- typo3/sysext/core/Classes/Tree/TableConfiguration/AbstractTableConfigurationTreeDataProvider.php+2 −2
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php7+9 −14
Review log 1317
-
Benni Mack uploaded patch set 1 11/05/22, 15:07
-
core-ci voted on patch set 1 V -1 11/05/22, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33147
-
Benni Mack uploaded patch set 2 11/05/22, 15:34
-
core-ci voted on patch set 2 V +1 11/05/22, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33148
-
Kevin Appelt voted on patch set 2 CR +1 11/05/22, 15:44
-
Oliver Klee commented on patch set 2 11/05/22, 16:08
DatabaseTreeDataProvider.php:56This should stay as this allows PHPStan to have further checks when writing/reading this property.DatabaseTreeDataProvider.php:134shorter: self::MODE_* (and also drop the int)DatabaseTreeDataProvider.php:144shorter: self::MODE_* (and also drop the int) -
Oliver Klee commented on patch set 2 CR -1 11/05/22, 16:12
DatabaseTreeDataProvider.php:134ReplyReference for this: https://phpstan.org/writing-php-code/phpdoc-types#literals-and-constants -
Benni Mack uploaded patch set 3 11/05/22, 19:22
-
core-ci voted on patch set 3 V +1 11/05/22, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33150
-
Oliver Klee commented on patch set 3 CR +1 11/05/22, 19:33
TreeNode.php:119ReplyDoneDatabaseTreeDataProvider.php:56ReplyDoneDatabaseTreeDataProvider.php:134ReplyDoneDatabaseTreeDataProvider.php:144ReplyDone -
Benni Mack rebased onto patch set 4 11/05/22, 21:08
-
core-ci voted on patch set 4 V +1 11/05/22, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33152
-
Markus Klein voted on patch set 4 V +1 CR +1 11/05/22, 22:13
-
Oliver Klee voted on patch set 4 CR +1 11/05/22, 23:02
-
Georg Ringer voted on patch set 4 V +1 CR +1 11/06/22, 05:23
-
Oli Bartsch voted on patch set 4 V +2 CR +2 11/06/22, 09:15
-
Oli Bartsch merged patch set 5 11/06/22, 09:15
TreeNode.php:119