Review main Merged

76446[BUGFIX] Speed up FormEngine with selective workspaceOL() calls

Benni Mack CR +2 V +2 Normal +126 −69 updated 11/14/22, 16:12

Commit message

BackendUtility::getPossibleWorkspaceVersionIdsOfLiveRecordIds()
is added to check for workspace versions within FormEngine
foreign_field logic to first fetch a list of all records
that have a versioned record within the workspace, and only
apply BackendUtility::workspaceOL() for these cases.

Without the patch, each live record triggers a database
query to resolve a possible workspace overlay. With the
patch, one query is done to see which records have
workspace overlays, only those are queried for overlays.
This reduces the number of performed queries a lot, since
typically only a small number of records are overlaid.

This only affects editing records in a workspace.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1828

Show 23 earlier messages
  1. Benni Mack uploaded patch set 1 11/05/22, 21:12

  2. core-ci voted on patch set 1 V -1 11/05/22, 21:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33154

  3. Benni Mack rebased onto patch set 2 11/06/22, 13:25

  1. Oliver Klee commented on patch set 2 11/06/22, 13:29

    BackendUtility.php:3110

    There's a comma missing: array<int, int>
  2. Benni Mack updated the commit message in patch set 3 11/06/22, 13:34

  3. Benni Mack commented on patch set 4 11/06/22, 13:35

    Published edit on patch set 3.
  4. Benni Mack commented on patch set 4 11/06/22, 13:35

    BackendUtility.php:3110 Reply

    Thanks, fixed!
  5. core-ci voted on patch set 2 V -1 11/06/22, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33166

  6. core-ci voted on patch set 4 V -1 11/06/22, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33169

  7. core-ci voted on patch set 3 V -1 11/06/22, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33168

  8. Benni Mack uploaded patch set 5 11/06/22, 14:16

  9. core-ci voted on patch set 5 V +1 11/06/22, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33170

  10. Benni Mack uploaded patch set 6 11/06/22, 21:38

  11. core-ci voted on patch set 6 V +1 11/06/22, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33171

  12. Andreas Kienast voted on patch set 6 CR +1 11/07/22, 10:05

  13. Benni Mack uploaded patch set 7 11/07/22, 11:12

  14. core-ci voted on patch set 7 V +1 11/07/22, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33186

  15. Benni Mack rebased onto patch set 8 11/11/22, 10:14

  16. core-ci voted on patch set 8 V +1 11/11/22, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33559

  17. Christian Kuhn uploaded patch set 9 11/14/22, 09:56

  18. Christian Kuhn uploaded patch set 10 11/14/22, 09:57

  19. Christian Kuhn voted on patch set 10 V +1 CR +1 11/14/22, 09:58

  20. core-ci voted on patch set 9 V +1 11/14/22, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33693

  21. core-ci voted on patch set 10 V +1 11/14/22, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33694

  22. Andreas Kienast voted on patch set 10 CR +1 11/14/22, 10:51

  23. Stefan Bürk voted on patch set 10 V +1 CR +1 11/14/22, 15:30

  24. Benni Mack voted on patch set 10 V +2 CR +2 11/14/22, 16:12

  25. Benni Mack merged patch set 11 11/14/22, 16:12