Review main Merged

76449[FEATURE] Allow global services configuration

Chris Müller CR +2 V +2 Normal +69 −0 updated 11/11/22, 12:56

Commit message

The Service Configuration for the dependency container
is now also checked in `config/system/services.yaml` or
`config/system/services.php`.

Note that this only works in Composer-based
installations where the project root is outside
the document root.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 2838

Show 913 earlier messages
  1. Chris Müller uploaded patch set 1 11/07/22, 10:00

  2. Chris Müller wrote 11/07/22, 10:01

    Topic set to di
  3. Andreas Kienast commented on patch set 1 CR -1 11/07/22, 10:06

    ContainerBuilder.php:127

    Should be YamlFileLoader
  4. core-ci voted on patch set 1 V +1 11/07/22, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33180

  5. Chris Müller uploaded patch set 2 11/07/22, 10:11

  6. Chris Müller commented on patch set 2 11/07/22, 10:12

    ContainerBuilder.php:127 Reply

    Done
  7. core-ci voted on patch set 2 V +1 11/07/22, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33181

  8. Chris Müller updated the commit message in patch set 3 11/07/22, 14:48

  9. core-ci voted on patch set 3 V +1 11/07/22, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33215

  10. Stefan Bürk commented on patch set 3 11/07/22, 15:55

    ContainerBuilder.php:127

    Should be $yamlFileLoader to match the type
  11. Chris Müller uploaded patch set 4 11/07/22, 17:49

  12. Chris Müller commented on patch set 4 11/07/22, 17:50

    ContainerBuilder.php:127 Reply

    Done
  13. core-ci voted on patch set 4 V +1 11/07/22, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33221

  1. Georg Ringer commented on patch set 4 CR -1 11/07/22, 19:10

    it would be very nice to have a rst with an example
  2. Chris Müller uploaded patch set 5 11/07/22, 19:30

  3. core-ci voted on patch set 5 V +1 11/07/22, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33223

  4. Benni Mack uploaded patch set 6 11/07/22, 19:43

  5. core-ci voted on patch set 6 V +1 11/07/22, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33225

  6. Benni Mack voted on patch set 6 CR +1 11/08/22, 09:45

  7. Benjamin Franzke commented on patch set 6 11/08/22, 10:09

    Fine by me, but let's stay with lowercase-only for system-wide configuration files in order to be consistent with all the other ones. So: Drop Services.php and Services.yaml.
  8. Benni Mack commented on patch set 7 11/08/22, 18:03

    Published edit on patch set 6.
  9. Benni Mack updated the commit message in patch set 8 11/08/22, 18:03

  10. core-ci voted on patch set 7 V +1 11/08/22, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33334

  11. core-ci voted on patch set 8 V +1 11/08/22, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33335

  12. Benni Mack voted on patch set 8 CR +1 11/08/22, 19:50

  13. Benjamin Franzke commented on patch set 8 11/09/22, 07:38

    ContainerBuilder.php:122

    To summarize: We now have: config/system/settings.php config/system/additional.php config/sites/*/config.yaml and these are added now: config/services.yaml config/services.php Feels a bit inconsistent, but I don't have a better idea, so just saying. (config/services/{whatever}.php would not be better)

    Feature-98912-Installation-wide-ServicesConfiguration.rst:25

    this is a typo, right? It would be typo3conf/.
  14. Benni Mack uploaded patch set 9 11/09/22, 09:18

  15. Benni Mack commented on patch set 9 CR +1 11/09/22, 09:19

    Feature-98912-Installation-wide-ServicesConfiguration.rst:25 Reply

    Done
  16. core-ci voted on patch set 9 V +1 11/09/22, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33386

  17. Georg Ringer voted on patch set 9 CR +1 11/09/22, 21:45

  18. Susi Moog commented on patch set 9 CR -1 11/11/22, 10:26

    ContainerBuilder.php:125

    can we move this to /system ? It looks weird to have the folders sites and system and then next to that these two files.
  19. Benni Mack uploaded patch set 10 11/11/22, 10:31

  20. core-ci voted on patch set 10 V +1 11/11/22, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33562

  21. Benjamin Franzke voted on patch set 10 CR +1 11/11/22, 11:42

  22. Susi Moog voted on patch set 10 CR +1 11/11/22, 12:47

  23. Susi Moog voted on patch set 10 V +1 11/11/22, 12:50

  24. Benni Mack commented on patch set 10 V +2 CR +2 11/11/22, 12:56

    ContainerBuilder.php:125 Reply

    Done
  25. Benni Mack merged patch set 11 11/11/22, 12:56