Review main Merged

76450[BUGFIX] Disable language (de)activation with write-protected configuration

Andreas Kienast CR +2 V +2 Hard +156 −107 updated 07/06/23, 10:21

Commit message

The language management module writes into system/settings.php to
either enable or disable a language. With the changes made with #98957,
the language management should also inform about a write-protected
configuration file and remove any options that conflict with this
state.

This patch removes any option to either enable or disable a language and
moves the Fluid partial to a more generic location aimed for multiple
usages across several modules.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 13

Review log 811

  1. Andreas Kienast uploaded patch set 1 11/07/22, 10:57

  2. core-ci voted on patch set 1 V -1 11/07/22, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33183

  3. Andreas Kienast uploaded patch set 2 11/07/22, 11:10

  4. core-ci voted on patch set 2 V +1 11/07/22, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33185

  5. Georg Ringer voted on patch set 2 V +1 CR +1 01/13/23, 06:56

  6. Susi Moog uploaded patch set 3 CR +1 V +1 07/04/23, 13:36

  7. core-ci voted on patch set 3 V +1 07/04/23, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43385

  8. Susi Moog voted on patch set 3 V +1 CR +1 07/05/23, 19:39

  9. Benni Mack voted on patch set 3 V +1 CR +1 07/06/23, 10:19

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 07/06/23, 10:21

  11. Andreas Kienast merged patch set 4 07/06/23, 10:21