Review main Merged

76456[FEATURE] Add a description field to redirects

Christoph Schwob CR +2 V +2 Easy +43 −1 updated 11/09/22, 10:49

Commit message

Add a description field also for redirects, which
could be used to add notes for further handling of
the correpsonding redirect. This follows the same
logic like for other record types.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1724

  1. Christoph Schwob uploaded patch set 1 11/07/22, 13:07

  2. core-ci voted on patch set 1 V -1 11/07/22, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33197

  3. Andreas Kienast commented on patch set 1 CR -1 11/07/22, 15:07

    Please tell something more about that feature. Also, a ReST file is missing.
    What kind of description field?
    main
  4. Christoph Schwob uploaded patch set 2 11/07/22, 15:26

  5. Christoph Schwob updated the commit message in patch set 3 11/07/22, 15:28

  6. core-ci voted on patch set 3 V +1 11/07/22, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33218

  7. core-ci voted on patch set 2 V +1 11/07/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33217

  8. Oli Bartsch commented on patch set 3 V -1 11/07/22, 16:19

    Reply

    Feature RST is still missing
  9. Christian Kuhn commented on patch set 3 11/07/22, 17:00

    sys_redirect.php:5

    'descriptionColumn' => 'rowDescription',

    ext_tables.sql:10

    not needed with the TCA ctrl setting.
  10. Christoph Schwob uploaded patch set 4 11/07/22, 17:30

  11. core-ci voted on patch set 4 V +1 11/07/22, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33220

  12. Georg Ringer voted on patch set 4 V +1 CR +1 11/07/22, 19:10

  13. Stefan Bürk commented on patch set 4 11/08/22, 12:32

    Should we ensure that the description field is not added to the redirect mathcing cache ?
  14. Stefan Bürk uploaded patch set 5 11/08/22, 21:56

  15. Stefan Bürk commented on patch set 5 11/08/22, 21:57

    Reply

    Done

    Reply

    Done

    Reply

    Done

    Reply

    Done

    sys_redirect.php:5 Reply

    Done

    ext_tables.sql:10 Reply

    Done
  16. Stefan Bürk uploaded patch set 6 11/08/22, 22:00

  17. core-ci voted on patch set 5 V +1 11/08/22, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33360

  18. core-ci voted on patch set 6 V +1 11/08/22, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33361

  19. Oli Bartsch commented on patch set 6 CR -1 11/08/22, 22:54

    RST should receive a bit more love. Will have a look tomorrow if nobody else steps in.
  20. Oli Bartsch uploaded patch set 7 11/09/22, 10:19

  21. Stefan Bürk voted on patch set 7 V +1 CR +1 11/09/22, 10:20

  22. core-ci voted on patch set 7 V +1 11/09/22, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33391

  23. Georg Ringer voted on patch set 7 V +2 CR +2 11/09/22, 10:49

  24. Georg Ringer merged patch set 8 11/09/22, 10:49