Review main Merged

76459[BUGFIX] Resolve shortcut to a different page in a localized page

Benni Mack CR +2 V +2 Normal +51 −12 updated 07/05/23, 20:32

Commit message

When a page translation of type=shortcut (doktype=4)
contains a different value than its original
page, the proper target URL is now resolved correctly
upon link creation and link resolving in TSFE.

This additionally fixes flaws in the behavior of first subpage in cases where the first subpage differs between languages.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 914

  1. Benni Mack uploaded patch set 1 11/07/22, 16:31

  2. core-ci voted on patch set 1 V -1 11/07/22, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33219

  3. Benni Mack updated the commit message in patch set 2 V -1 05/03/23, 09:25

  4. core-ci voted on patch set 2 V -1 05/03/23, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41410

  5. Susi Moog uploaded patch set 3 V -1 07/05/23, 15:34

  6. core-ci voted on patch set 3 V -1 07/05/23, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43548

  7. Susi Moog updated the commit message in patch set 4 V -1 07/05/23, 15:55

  8. core-ci voted on patch set 4 V -1 07/05/23, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43552

  9. Benni Mack rebased onto patch set 5 V -1 07/05/23, 17:31

  10. core-ci voted on patch set 5 V +1 07/05/23, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43570

  11. Susi Moog voted on patch set 5 V +1 CR +1 07/05/23, 18:41

  12. Oli Bartsch voted on patch set 5 V +1 CR +1 07/05/23, 20:14

  13. Benni Mack voted on patch set 5 V +2 CR +2 07/05/23, 20:32

  14. Benni Mack merged patch set 6 07/05/23, 20:32